Fixed nesting when ExceptionRenderer throws exception

cakephp · Jan 15, 2015 · f621bb7 · f621bb7
1 parent d39c744
commit f621bb7
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 2 deletions.
diff --git a/lib/Cake/Error/ErrorHandler.php b/lib/Cake/Error/ErrorHandler.php
@@ -125,6 +125,8 @@ public static function handleException(Exception $exception) {
 				$e->getMessage(),
 				$e->getTraceAsString()
 			);
+
+			Configure::write('Exception.bail', true);
 			trigger_error($message, E_USER_ERROR);
 		}
 	}
@@ -249,10 +251,17 @@ public static function handleFatalError($code, $description, $file, $line) {
 		}
 
 		if (Configure::read('debug')) {
-			call_user_func($exceptionHandler, new FatalErrorException($description, 500, $file, $line));
+			$exception = new FatalErrorException($description, 500, $file, $line);
 		} else {
-			call_user_func($exceptionHandler, new InternalErrorException());
+			$exception = new InternalErrorException();
+		}
+
+		if (Configure::read('Exception.bail')) {
+			throw $exception;
 		}
+
+		call_user_func($exceptionHandler, $exception);
+
 		return false;
 	}
 

diff --git a/lib/Cake/Test/Case/Error/ErrorHandlerTest.php b/lib/Cake/Test/Case/Error/ErrorHandlerTest.php
@@ -20,6 +20,16 @@
 App::uses('Controller', 'Controller');
 App::uses('Router', 'Routing');
 
+/**
+ * A faulty ExceptionRenderer to test nesting.
+ */
+class FaultyExceptionRenderer extends ExceptionRenderer {
+
+	public function render() {
+		throw new Exception('Error from renderer.');
+	}
+}
+
 /**
  * ErrorHandlerTest class
  *
@@ -320,4 +330,28 @@ public function testHandleFatalErrorLog() {
 		$this->assertContains('[FatalErrorException] Something wrong', $log[1], 'message missing.');
 	}
 
+/**
+ * testExceptionRendererNestingDebug method
+ *
+ * @expectedException FatalErrorException
+ * @return void
+ */
+	public function testExceptionRendererNestingDebug() {
+		Configure::write('debug', 2);
+		Configure::write('Exception.renderer', 'FaultyExceptionRenderer');
+		ErrorHandler::handleFatalError(E_USER_ERROR, 'Initial error', __FILE__ ,__LINE__);
+	}
+
+/**
+ * testExceptionRendererNestingProduction method
+ *
+ * @expectedException InternalErrorException
+ * @return void
+ */
+	public function testExceptionRendererNestingProduction() {
+		Configure::write('debug', 0);
+		Configure::write('Exception.renderer', 'FaultyExceptionRenderer');
+		ErrorHandler::handleFatalError(E_USER_ERROR, 'Initial error', __FILE__ ,__LINE__);
+	}
+
 }