cardmagic / scriptaculous fork watch download tarball
public
Fork of madrobby/scriptaculous
Description: script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
Homepage: http://script.aculo.us/
Clone URL: git://github.com/cardmagic/scriptaculous.git
Click here to lend your support to: scriptaculous and make a donation at www.pledgie.com ! 
script.aculo.us: Fix an issue with Effect.ScrollTo that caused Firefox to 
scroll to the wrong offset in some situations. Closes #10245.

git-svn-id: http://svn.rubyonrails.org/rails/spinoffs/scriptaculous@8686 
5ecf4fe2-1ee6-0310-87b1-e25e094e27de
madrobby (author)
Mon Jan 21 15:22:29 -0800 2008
commit  115b86defe984a47e9fe61e4bdccd870b54edb82
tree    6bb739bdc6c539b00895fde310a8261765edd4f2
parent  47fa18a622fabc87248b193fff833393d7c2982e
0
CHANGELOG 
...
 
 
1
2
3
 
...
1
2
3
4
5
 
0
@@ -1,3 +1,5 @@
0
+* Fix an issue with Effect.ScrollTo that caused Firefox to scroll to the wrong offset in some situations. Closes #10245.  [nik.wakelin]
0
+
0
 * Fixes an issue with IE ghosting on non-absolute elements. Closes #10423.  [Tanrikut, tdd]
0
 
0
 *V1.8.1* (January 3, 2008)
0
src/effects.js 
...
509
510
511
512
 
513
514
515
 
...
509
510
511
 
512
513
514
515
 
0
@@ -509,7 +509,7 @@ Effect.ScrollTo = function(element) {
0
   var options = arguments[1] || { },
0
     scrollOffsets = document.viewport.getScrollOffsets(),
0
     elementOffsets = $(element).cumulativeOffset(),
0
-    max = (window.height || document.body.scrollHeight) - document.viewport.getHeight();  
0
+    max = document.viewport.getScrollOffsets[0] - document.viewport.getHeight(); 
0
 
0
   if (options.offset) elementOffsets[1] += options.offset;
0
 
0
test/functional/index.html 
...
35
36
37
 
38
39
40
 
...
35
36
37
38
39
40
41
 
0
@@ -35,6 +35,7 @@
0
   <li><a href="effects3_test.html" target="test">effects3_test</a></li>
0
   <li><a href="effects4_test.html" target="test">effects4_test</a></li>
0
   <li><a href="effects5_test.html" target="test">effects5_test</a></li>
0
+  <li><a href="effects5b_test.html" target="test">effects5b_test</a></li>
0
   <li><a href="effects6_test.html" target="test">effects6_test</a></li>
0
   <li><a href="effect_shake.html" target="test">effect shake</a></li>
0
   <li><a href="effects_grow_strink_test.html" target="test">Grow/Shrink</a></li>

Comments

    No one has commented yet.