test/functional/effects5b_test.html @@ -1,3 +1,5 @@ +* Fix an issue with Effect.ScrollTo that caused Firefox to scroll to the wrong offset in some situations. Closes #10245. [nik.wakelin] + * Fixes an issue with IE ghosting on non-absolute elements. Closes #10423. [Tanrikut, tdd] *V1.8.1* (January 3, 2008) CHANGELOG @@ -509,7 +509,7 @@ Effect.ScrollTo = function(element) { var options = arguments[1] || { }, scrollOffsets = document.viewport.getScrollOffsets(), elementOffsets = $(element).cumulativeOffset(), - max = (window.height || document.body.scrollHeight) - document.viewport.getHeight(); + max = document.viewport.getScrollOffsets[0] - document.viewport.getHeight(); if (options.offset) elementOffsets[1] += options.offset; src/effects.js @@ -35,6 +35,7 @@ <li><a href="effects3_test.html" target="test">effects3_test</a></li> <li><a href="effects4_test.html" target="test">effects4_test</a></li> <li><a href="effects5_test.html" target="test">effects5_test</a></li> + <li><a href="effects5b_test.html" target="test">effects5b_test</a></li> <li><a href="effects6_test.html" target="test">effects6_test</a></li> <li><a href="effect_shake.html" target="test">effect shake</a></li> <li><a href="effects_grow_strink_test.html" target="test">Grow/Shrink</a></li> test/functional/index.html 47fa18a622fabc87248b193fff833393d7c2982e Thomas Fuchs thomas@fesch.at http://github.com/cardmagic/scriptaculous/commit/115b86defe984a47e9fe61e4bdccd870b54edb82 115b86defe984a47e9fe61e4bdccd870b54edb82 2008-01-21T15:22:29-08:00 2008-01-21T15:22:29-08:00 script.aculo.us: Fix an issue with Effect.ScrollTo that caused Firefox to scroll to the wrong offset in some situations. Closes #10245. git-svn-id: http://svn.rubyonrails.org/rails/spinoffs/scriptaculous@8686 5ecf4fe2-1ee6-0310-87b1-e25e094e27de 6bb739bdc6c539b00895fde310a8261765edd4f2 Thomas Fuchs thomas@fesch.at