@@ -1,3 +1,5 @@ +* Fixed Effect.ScrollTo. Changeset 8686 had a typo, document.viewport.getScrollOffsets[0] is always undefined. Removed the max check as it is not a cross-browser way to get scroll height and breaks the effect. Depending on scrollTo to do the right thing. Closes #11306. [Nick Stakenburg] + * Update version check so all Prototype versions can be required, not just x.x.x. Closes #10966. [Nick Stakenburg] * Using $$ in the loader instead of getElementsByTagName to prevent limitations. Closes #9032. [Nick Stakenburg] CHANGELOG @@ -507,15 +507,14 @@ Effect.Highlight = Class.create(Effect.Base, { Effect.ScrollTo = function(element) { var options = arguments[1] || { }, - scrollOffsets = document.viewport.getScrollOffsets(), - elementOffsets = $(element).cumulativeOffset(), - max = document.viewport.getScrollOffsets[0] - document.viewport.getHeight(); + scrollOffsets = document.viewport.getScrollOffsets(), + elementOffsets = $(element).cumulativeOffset(); if (options.offset) elementOffsets[1] += options.offset; return new Effect.Tween(null, scrollOffsets.top, - elementOffsets[1] > max ? max : elementOffsets[1], + elementOffsets[1], options, function(p){ scrollTo(scrollOffsets.left, p.round()) } ); src/effects.js 951f483eac9016e3ce59a82618b12287aaff910a Nick Stakenburg nick@nickstakenburg.com http://github.com/cardmagic/scriptaculous/commit/65d299d93d39da9e941625e414d9c036f5c4ea46 65d299d93d39da9e941625e414d9c036f5c4ea46 2008-04-21T07:35:28-07:00 2008-04-21T07:35:28-07:00 Fixed Effect.ScrollTo. d89cfc5d3e0b67093dbb94ddba9b95b217d92008 Nick Stakenburg nick@nickstakenburg.com