public
Fork of madrobby/scriptaculous
Description: script.aculo.us is an open-source JavaScript framework for visual effects and interface behaviours.
Homepage: http://script.aculo.us/
Clone URL: git://github.com/cardmagic/scriptaculous.git
Click here to lend your support to: scriptaculous and make a donation at www.pledgie.com !
Fixed Effect.ScrollTo.
staaky (author)
Mon Apr 21 07:35:28 -0700 2008
commit  65d299d93d39da9e941625e414d9c036f5c4ea46
tree    d89cfc5d3e0b67093dbb94ddba9b95b217d92008
parent  951f483eac9016e3ce59a82618b12287aaff910a
...
 
 
1
2
3
...
1
2
3
4
5
0
@@ -1,3 +1,5 @@
0
+* Fixed Effect.ScrollTo. Changeset 8686 had a typo, document.viewport.getScrollOffsets[0] is always undefined. Removed the max check as it is not a cross-browser way to get scroll height and breaks the effect. Depending on scrollTo to do the right thing. Closes #11306. [Nick Stakenburg]
0
+
0
 * Update version check so all Prototype versions can be required, not just x.x.x. Closes #10966. [Nick Stakenburg]
0
 
0
 * Using $$ in the loader instead of getElementsByTagName to prevent limitations. Closes #9032. [Nick Stakenburg]
...
507
508
509
510
511
512
 
 
513
514
515
516
517
518
 
519
520
521
...
507
508
509
 
 
 
510
511
512
513
514
515
516
 
517
518
519
520
0
@@ -507,15 +507,14 @@ Effect.Highlight = Class.create(Effect.Base, {
0
 
0
 Effect.ScrollTo = function(element) {
0
   var options = arguments[1] || { },
0
- scrollOffsets = document.viewport.getScrollOffsets(),
0
- elementOffsets = $(element).cumulativeOffset(),
0
- max = document.viewport.getScrollOffsets[0] - document.viewport.getHeight();
0
+ scrollOffsets = document.viewport.getScrollOffsets(),
0
+ elementOffsets = $(element).cumulativeOffset();
0
 
0
   if (options.offset) elementOffsets[1] += options.offset;
0
 
0
   return new Effect.Tween(null,
0
     scrollOffsets.top,
0
- elementOffsets[1] > max ? max : elementOffsets[1],
0
+ elementOffsets[1],
0
     options,
0
     function(p){ scrollTo(scrollOffsets.left, p.round()) }
0
   );

Comments

    No one has commented yet.