@@ -381,7 +381,7 @@ static ngx_int_t ngx_http_push_subscriber_handler(ngx_http_request_t *r) { msg->received++; } //is the message still needed? - if(msg!=NULL && msg->queue.next==NULL && (--msg->refcount)==0) { + if(msg!=NULL && (--msg->refcount)==0 && msg->queue.next==NULL) { //message was dequeued, and nobody needs it anymore ngx_http_push_free_message_locked(msg, shpool); } @@ -831,7 +831,7 @@ static ngx_int_t ngx_http_push_respond_to_subscribers(ngx_http_push_channel_t *c ngx_shmtx_lock(&shpool->mutex); channel->subscribers-=responded_subscribers; //is the message still needed? - if(msg!=NULL && msg->queue.next==NULL && (--msg->refcount)==0) { + if(msg!=NULL && (--msg->refcount)==0 && msg->queue.next==NULL) { //message was dequeued, and nobody needs it anymore ngx_http_push_free_message_locked(msg, shpool); } src/ngx_http_push_module.c 059ebe067a179775b2e414e2cca4479ecb169861 Leo P junk@slact.net http://github.com/carsonbaker/nginx_http_push_module/commit/fdc56681a77361eb632b34ec08728e6a1043f585 fdc56681a77361eb632b34ec08728e6a1043f585 2009-11-06T01:33:26-08:00 2009-11-06T01:33:26-08:00 message removal refcount bugfix 442675fbfa81b70fc9c1c12bf1bebd2dce56979a Leo P junk@slact.net