Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking issues in text area #2826

Closed
L3P3 opened this issue Mar 6, 2021 · 4 comments
Closed

Clicking issues in text area #2826

L3P3 opened this issue Mar 6, 2021 · 4 comments
Labels
stale This issue has not had activity in a while and will be closed waiting-for-info Waiting for more information from submitter
Projects
Milestone

Comments

@L3P3
Copy link
Contributor

L3P3 commented Mar 6, 2021

  • Web Browser: Mypal 29.0.1 (Pale Moon/Firefox)
  • Local OS: Windows XP SP3
  • Remote OS: Debian 10
  • Remote Architecture: x86-64
  • code-server --version: 3.9.0 fc6d123
  1. When right-clicking in the text area (and only there), the context menu does not appear. Following error is thrown:
  ERR this.shadowRootHostElement.attachShadow is not a function: setContainer@out/vs/workbench/workbench.web.api.js:448:617
setContainer@out/vs/workbench/workbench.web.api.js:1724:79
showContextView@out/vs/workbench/workbench.web.api.js:1724:180
showContextMenu@out/vs/workbench/workbench.web.api.js:2171:372
showContextMenu@out/vs/workbench/workbench.web.api.js:2524:362
_doShowContextMenu@out/vs/workbench/workbench.web.api.js:2036:481
showContextMenu@out/vs/workbench/workbench.web.api.js:2035:614
_onContextMenu@out/vs/workbench/workbench.web.api.js:2035:347
e/<@out/vs/workbench/workbench.web.api.js:2034:213
fire@out/vs/workbench/workbench.web.api.js:99:694
_createView/i.onContextMenu@out/vs/workbench/workbench.web.api.js:2357:766
emitContextMenu@out/vs/workbench/workbench.web.api.js:2215:957
emitContextMenu@out/vs/workbench/workbench.web.api.js:2007:54
_onContextMenu@out/vs/workbench/workbench.web.api.js:2202:979
p/<@out/vs/workbench/workbench.web.api.js:2201:318
onContextMenu/<@out/vs/workbench/workbench.web.api.js:479:433
  1. When clicking on empty lines, nothing happens (cursor does not jump to that line), no error is thrown. Clicking on lines containing text behaves correctly. Is quite annoying, have to always click on nearest populated line and navigate down/up via keyboard.
@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 8, 2021

Hmm... can you provide reproduction steps? I don't have a Windows XP machine around and I haven't used Mypal but willing to try and test on my machine locally.

@jsjoeio jsjoeio added the waiting-for-info Waiting for more information from submitter label Mar 8, 2021
@jsjoeio jsjoeio added this to Triage in code-server via automation Mar 8, 2021
@L3P3
Copy link
Contributor Author

L3P3 commented Mar 9, 2021

The reproduction steps are like this:
Install mypal, open the app, right click in code editor area. 😉

The reason ist obvious to me: Mypal is based on a firefox version older than 63, lacking support of shadow dom.
I see no reason for using shadowDom in vscode anyway, maybe it can be replaced by something older without any issues.
If not, there is at least one polyfill for shadowDom available, it should be fairly easy to integrate that into the app.

@code-asher
Copy link
Member

code-asher commented Mar 9, 2021 via email

@jsjoeio jsjoeio added this to the Backlog milestone Apr 29, 2021
@stale
Copy link

stale bot commented Oct 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no activity occurs in the next 5 days.

@stale stale bot added the stale This issue has not had activity in a while and will be closed label Oct 27, 2021
@L3P3 L3P3 closed this as completed Oct 28, 2021
jsjoeio added a commit that referenced this issue Dec 15, 2021
* Support browsers from before 2020

As reported in #2825, #2826 and #3051, almost everything works in older browsers. This setting here prevented me from updating and I think it is an obvious enhancement to not restrict to browsers from 2020+. There should not be any measurable downsides of this change since es6 and es2020 are pretty similar with only minor differences.

* Include lib (polyfills) for <es2020 targets

* Assume all modern dom features despite es6 syntax

* Add modern dom iterators to es6 environment

Co-authored-by: Joe Previte <jjprevite@gmail.com>
Co-authored-by: Asher <ash@coder.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue has not had activity in a while and will be closed waiting-for-info Waiting for more information from submitter
Projects
No open projects
Development

No branches or pull requests

3 participants