jewel: msgr: msg/async: connection race hang #10003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we use a tricky with ceph msgr protocol, if initiator side got in progress connection state, it will wait until read event. Because if tcp session built successfully server side will send the banner firstly and initiator side will get read event. Otherwise, if connection failed, read event also be called. But actually man(2)[http://man7.org/linux/man-pages/man2/connect.2.html] specify if we want to get notification whether connection built, we need to listen writable event. It means when connection built, send buffer is ready to be written. This patch follow the strict nonblock connect process. Not fully sure fix http://tracker.ceph.com/issues/15849 Signed-off-by: Haomai Wang <haomai@xsky.com> (cherry picked from commit a74ce41)
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Jun 30, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 1, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@yuyuyu101 does this backport look good to merge ? It passed the rados suite http://tracker.ceph.com/issues/16344#note-13 |
|
lgtm |
ghost
merged commit
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16380