jewel: mds: Session::check_access() is buggy #10105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It calls CInode::make_path_string(...) with the second argument is false. The second argument makes the third argument useless. For newly created inode, the path string is something like #1xxxxxxxxx. This can cause the access check to fail. Fixes: http://tracker.ceph.com/issues/16358 Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit a94ef56)
xiaoxichen
force-pushed
the
wip-16515-jewel
branch
from
06bfe26
to
64d99b1
Compare
|
@xiaoxichen I'm setting milestone jewel since this is targeting jewel really. If that's a mistake please let me know. |
ghost
pushed a commit
that referenced
this pull request
Aug 8, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
Hey jenkins, test this please ! |
ghost
pushed a commit
that referenced
this pull request
Aug 9, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 12, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@gregsfortytwo does this backport look good to merge ? It passed the fs suite http://tracker.ceph.com/issues/16344#note-21 (except for unrelated valgrind failures and one transient failure that is, I believe, unrelated ). |
ghost
pushed a commit
that referenced
this pull request
Aug 16, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 17, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
Yep, looks good to me @dachary! |
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16515