New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jewel: rgw: fix multi-delete query param parsing. #10188
Conversation
Multi-delete is triggered by a query parameter on POST, but there are multiple valid ways of representing it, and Ceph should accept ANY way that has the query parameter set, regardless of what value or absence of value. This caused the RubyGem aws-sdk-v1 to break, and has been present since multi-delete was first added in commit 0a1f4a9, for the bobtail release. Fixes: http://tracker.ceph.com/issues/16618 Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com> (cherry picked from commit a7016e1)
Marking DNM until master commit #10187 is merged and backport staged. |
@yehudasa @smithfarm please merge here too, already merged on master+jewel. |
@robbat2 This PR is targeting jewel. It won't be merged until it passes integration tests in http://tracker.ceph.com/issues/16344 |
Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@robbat2 FYI tests are currently scheduled at http://pulpito.ceph.com/loic-2016-08-10_07:00:21-rgw-jewel-backports---basic-smithi/ |
…arsing. Reviewed-by: Loic Dachary <ldachary@redhat.com>
@yehudasa does this backport look good to merge ? It passed the rgw suite http://tracker.ceph.com/issues/16344#note-19 (the failure was due to another pull request). |
…arsing. Reviewed-by: Loic Dachary <ldachary@redhat.com>
…arsing. Reviewed-by: Loic Dachary <ldachary@redhat.com>
…arsing. Reviewed-by: Loic Dachary <ldachary@redhat.com>
…arsing. Reviewed-by: Loic Dachary <ldachary@redhat.com>
Backport: http://tracker.ceph.com/issues/16699
Multi-delete is triggered by a query parameter on POST, but there are
multiple valid ways of representing it, and Ceph should accept ANY way
that has the query parameter set, regardless of what value or absence of
value.
This caused the RubyGem aws-sdk-v1 to break, and has been present since
multi-delete was first added in commit 0a1f4a9, for the bobtail
release.
Fixes: http://tracker.ceph.com/issues/16618
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com
(cherry picked from commit a7016e1)