Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: fix multi-delete query param parsing. #10188

Merged
merged 1 commit into from Aug 22, 2016

Conversation

robbat2
Copy link
Contributor

@robbat2 robbat2 commented Jul 7, 2016

Backport: http://tracker.ceph.com/issues/16699

Multi-delete is triggered by a query parameter on POST, but there are
multiple valid ways of representing it, and Ceph should accept ANY way
that has the query parameter set, regardless of what value or absence of
value.

This caused the RubyGem aws-sdk-v1 to break, and has been present since
multi-delete was first added in commit 0a1f4a9, for the bobtail
release.

Fixes: http://tracker.ceph.com/issues/16618
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com
(cherry picked from commit a7016e1)

Multi-delete is triggered by a query parameter on POST, but there are
multiple valid ways of representing it, and Ceph should accept ANY way
that has the query parameter set, regardless of what value or absence of
value.

This caused the RubyGem aws-sdk-v1 to break, and has been present since
multi-delete was first added in commit 0a1f4a9, for the bobtail
release.

Fixes: http://tracker.ceph.com/issues/16618
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
(cherry picked from commit a7016e1)
@smithfarm smithfarm changed the title rgw: fix multi-delete query param parsing. [DNM] rgw: fix multi-delete query param parsing. Jul 8, 2016
@smithfarm
Copy link
Contributor

Marking DNM until master commit #10187 is merged and backport staged.

@smithfarm smithfarm added this to the jewel milestone Jul 8, 2016
@smithfarm smithfarm changed the title [DNM] rgw: fix multi-delete query param parsing. rgw: fix multi-delete query param parsing. Jul 16, 2016
@robbat2
Copy link
Contributor Author

robbat2 commented Jul 29, 2016

@yehudasa @smithfarm please merge here too, already merged on master+jewel.

@smithfarm
Copy link
Contributor

@robbat2 This PR is targeting jewel. It won't be merged until it passes integration tests in http://tracker.ceph.com/issues/16344

ghost pushed a commit that referenced this pull request Aug 8, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 9, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost changed the title rgw: fix multi-delete query param parsing. jewel: rgw: fix multi-delete query param parsing. Aug 10, 2016
@ghost
Copy link

ghost commented Aug 10, 2016

@ghost ghost self-assigned this Aug 10, 2016
ghost pushed a commit that referenced this pull request Aug 12, 2016
…arsing.

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link

ghost commented Aug 15, 2016

@yehudasa does this backport look good to merge ? It passed the rgw suite http://tracker.ceph.com/issues/16344#note-19 (the failure was due to another pull request).

@ghost ghost assigned yehudasa Aug 15, 2016
ghost pushed a commit that referenced this pull request Aug 16, 2016
…arsing.

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 17, 2016
…arsing.

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 22, 2016
…arsing.

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 22, 2016
…arsing.

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@oritwas oritwas merged commit 3f007a1 into ceph:jewel Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants