msg/simple/Pipe:the returned value for do_recv unequal to zero #10272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is do_recv() not returning 0 really part of the defined interface, or just a current implementation? I guess we can merge this on the first but the <= doesn't cost any more than < and changing it reduces resiliency to future changes... |
yonghengdexin735
force-pushed
the
wip-zzz-delete=
branch
from
7d4f624
to
96da884
Compare
|
jenkins test this please (jenkins stuck) |
yonghengdexin735
force-pushed
the
wip-zzz-delete=
branch
from
96da884
to
2b22f04
Compare
|
@dachary done |
ghost
added
the
|
@yonghengdexin735 you need to update the commit message, it won't work if you update the github web interface message |
the returned value for do_recv unequal to zero:
ssize_t Pipe::do_recv(char *buf, size_t len, int flags)
{
again:
ssize_t got = ::recv( sd, buf, len, flags );
if (got < 0) {
if (errno == EINTR) {
goto again;
}
ldout(msgr->cct, 10) << **func** << " socket " << sd << " returned "
<< got << " " << cpp_strerror(errno) << dendl;
return -1;
}
if (got == 0) {
return -1;
}
return got;
}
so here '=' can be removed
Signed-off-by: zhang.zezhu <zhang.zezhu@zte.com.cn>
yonghengdexin735
force-pushed
the
wip-zzz-delete=
branch
from
2b22f04
to
dd7a58b
Compare
|
@dachary Thank you for review.Done it. |
|
jenkins test this please (cephtool-test-mds.sh http://tracker.ceph.com/issues/18016) |
tchaikov
approved these changes
Mar 7, 2017
|
i think it's more consistent with the other caller site of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the returned value for do_recv unequal to zero:
so here '=' can be removed
Signed-off-by: zhang.zezhu zhang.zezhu@zte.com.cn