mon: OSDMonitor add check only concern our self cluster command #10309
Conversation
|
jenkins test this please |
| if (m->fsid != mon->monmap->fsid) { | ||
| dout(0) << "preprocess_pool_op: on fsid " << m->fsid | ||
| << " != " << mon->monmap->fsid << dendl; | ||
| return true; |
There was a problem hiding this comment.
I'm not entirely sure what the consequences of returning an error here would be, but silently dropping the message doesn't feel right.
We should figure out if there's an appropriate error to be replied to the consumer, and if so, make sure to use it.
There was a problem hiding this comment.
@jecluis Agree with that. I will add it later.
There was a problem hiding this comment.
passing an error string via the MPoolOpReply ::response_data is a viable way, but we need to change the interface of librados to return the error string. so returning an error code is fine here in the updated commit.
| @@ -7703,6 +7703,13 @@ bool OSDMonitor::preprocess_pool_op(MonOpRequestRef op) | |||
| { | |||
| op->mark_osdmon_event(__func__); | |||
| MPoolOp *m = static_cast<MPoolOp*>(op->get_req()); | |||
|
|
|||
| if (m->fsid != mon->monmap->fsid) { | |||
| dout(0) << "preprocess_pool_op: on fsid " << m->fsid | |||
There was a problem hiding this comment.
also, if we are outputting this error message on level 0, would certainly be nice to know which message is being dropped. I'd recommend fitting the message in here as well.
…uster command we only concern the commands send to ourself cluster Signed-off-by:song baisen <song.baisen@zte.com.cn>
songbaisen
force-pushed
the
b8
branch
2 times, most recently
from
03fcc16
to
ebea0ac
Compare
|
@jecluis Done it. |
|
@liewegas this was tested pls merge |
mon: OSDMonitor add check only concern our self cluster command
we only concern the command send to ourself cluster
Signed-off-by:song baisen song.baisen@zte.com.cn