jewel: mon: osdmonitor: decouple adjust_heartbeat_grace and min_down_reporters #10757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if cancel mon_osd_adjust_heartbeat_grace, we must set mon_osd_min_down_reporters to zero. otherwise the next checking for reporters_by_subtree.size() >= g_conf->mon_osd_min_down_reporters will allways be fail.the two options should take effect respectively... Signed-off-by: Zengran Zhang <zhangzengran@h3c.com> (cherry picked from commit 7ac5ca5)
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Aug 17, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 23, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 25, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@tchaikov does this backport look good to merge ? It passed the rados suite http://tracker.ceph.com/issues/17487#note-4 (except for one known bug that is, I believe, unrelated and one environmental failure on an erasure code job). |
ghost
pushed a commit
that referenced
this pull request
Oct 10, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 10, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 13, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
It passed the rados, upgrade/jewel-x and upgrade/hammer-x suites (except for two bugs that are, I believe, unrelated) |
ghost
pushed a commit
that referenced
this pull request
Oct 17, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 18, 2016
…rtbeat_grace and min_down_reporters Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
It passed the rados (http://tracker.ceph.com/issues/17487#note-19) suite except for two jobs that are, I believe unrelated. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17487#note-22) suites. |
|
lgtm. |
ghost
merged commit 
theanalyst
changed the title
theanalyst
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17056