jewel: osd: saw valgrind issues in ReplicatedPG::new_repop #10760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReplicatedPG::new_repop() returns a pointer to RepGather with two refcounts, one is held by ReplicatedPG::repop_queue, the other is supposed to be held by the caller of this function. but it's caller ReplicatedPG::submit_log_entries() assigns it to a boost::intrusive_ptr<RepGather>() directly, why by default add_ref() in its constructor. this makes the refcount 3. that's why we have a leak of RepGather in `ReplicatedPG::new_repop(ObcLockManager&&, boost::optional<std::function<void ()>>&&)`. Fixes: http://tracker.ceph.com/issues/16801 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit d3a2846)
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Aug 17, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 23, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 25, 2016
…::new_repop Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@tchaikov does this backport look good to merge ? It passed the rados suite http://tracker.ceph.com/issues/16344#note-39 (except for one known bug that is, I believe, unrelated and one environmental failure on an erasure code job). |
|
lgtm. |
ghost
merged commit 
theanalyst
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16865