hammer: build/ops: improve ceph.in error message #10905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov Do you know of any tests that rely on the old behavior? |
|
@smithfarm AFAIK, no. it's just a better error message. the old one is sort of misleading. |
smithfarm
changed the title
smithfarm
changed the title
smithfarm
added a commit
that referenced
this pull request
Nov 18, 2016
…essage Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Nov 20, 2016
…essage Reviewed-by: Nathan Cutler <ncutler@suse.com>
Fixes: ceph#11101 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit e19e8f1)
smithfarm
force-pushed
the
wip-11101-hammer
branch
from
b66c417
to
a3ba985
Compare
|
@liewegas This backport passed a rados suite at http://tracker.ceph.com/issues/17151#note-7 with failures that I believe have been addressed (except for http://tracker.ceph.com/issues/15139 which is caused by the build system no longer providing dumpling-era packages). I have rebuilt the integration branch to include the two fixes and scheduled a new run at http://tracker.ceph.com/issues/17151#note-14 Do you think it's OK to merge provided the second run succeeds? |
smithfarm
added a commit
that referenced
this pull request
Nov 21, 2016
…essage Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Nov 21, 2016
…essage Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
👍 |
|
Note this also passed an upgrade suite at http://tracker.ceph.com/issues/17151#note-18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11101
Signed-off-by: Kefu Chai kchai@redhat.com
(cherry picked from commit e19e8f1)