jewel: multisite: metadata master can get the wrong value for 'oldest_log_period' #11868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGWMetadataManager no longer makes stat calls on logs shards to determine its oldest_log_period. Instead, it records the oldest log's period id and realm_epoch in a rados object. If RGWMetadataManager::init_oldest_log_period() finds no such object, it calls find_oldest_period() to read period predecessors until it reaches the realm's first period, and writes that to rados. RGWMetadataManager::init_oldest_log_period() is now only called from RGWRados::init_complete() if run_sync_threads is true, instead of running unconditionally in RGWMetadataManager::init(), which allows us to skip building up a period history for radosgw-admin. Now that RGWMetadataManager::read_oldest_log_period() can return ENOENT for an uninitialized mdlog history, RGWRemoteMetaLog::run_sync() will retry on ENOENT as well. Fixes: http://tracker.ceph.com/issues/16894 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit d32654b) Conflicts: src/rgw/rgw_rados.cc: trivial context resolution
ghost
self-assigned this
ghost
changed the base branch from
|
jenkins test this please (general jenkins failure) |
ghost
pushed a commit
that referenced
this pull request
Nov 9, 2016
…the wrong value for 'oldest_log_period' Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@yehudasa does this backport look good to merge ? It passed the rgw suite http://tracker.ceph.com/issues/17851#note-3 . Note that it will not be in 10.2.4, reason why it targets jewel-next. |
ghost
pushed a commit
that referenced
this pull request
Nov 23, 2016
…the wrong value for 'oldest_log_period' Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Dec 5, 2016
…the wrong value for 'oldest_log_period' Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@yehudasa ping |
|
check this please |
1 similar comment
|
check this please |
|
This passed more rgw runs at http://tracker.ceph.com/issues/17851#note-50 and http://tracker.ceph.com/issues/17851#note-58 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17512