New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hammer: cephx: Fix multiple segfaults due to attempts to encrypt or decrypt #11930
Conversation
an empty secret and a null CryptoKeyHandler Fixes: http://tracker.ceph.com/issues/16266 Signed-off-by: Brad Hubbard <bhubbard@redhat.com> (cherry picked from commit 009e777)
…to attempts to encrypt or decrypt Reviewed-by: Nathan Cutler <ncutler@suse.com>
…to attempts to encrypt or decrypt Reviewed-by: Nathan Cutler <ncutler@suse.com>
@tchaikov @badone This backport passed a rados suite at http://tracker.ceph.com/issues/17151#note-7 with failures that I believe have been addressed (except for http://tracker.ceph.com/issues/15139 which is caused by the build system no longer providing dumpling-era packages). I have rebuilt the integration branch to include the two fixes and scheduled a new run at http://tracker.ceph.com/issues/17151#note-14 Do you think it's OK to merge provided the second run succeeds? |
Hey @smithfarm, thsnkd for working on this. I don't think any of the failures are directly related to this patch right? If they are unrelated I don't see any reason why we can't merge. |
@badone Right, the failures are not related to this PR. |
…to attempts to encrypt or decrypt Reviewed-by: Nathan Cutler <ncutler@suse.com>
…to attempts to encrypt or decrypt Reviewed-by: Nathan Cutler <ncutler@suse.com>
Second run succeeded; third run here: http://pulpito.front.sepia.ceph.com/smithfarm-2016-11-21_11:52:41-rados-hammer-backports---basic-smithi/ |
@smithfarm lgtm. |
http://tracker.ceph.com/issues/17346