Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hammer: cephx: Fix multiple segfaults due to attempts to encrypt or decrypt #11930

Merged
merged 1 commit into from Nov 23, 2016

Conversation

smithfarm
Copy link
Contributor

an empty secret and a null CryptoKeyHandler

Fixes: http://tracker.ceph.com/issues/16266
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit 009e777)
@smithfarm smithfarm self-assigned this Nov 12, 2016
@smithfarm smithfarm added this to the hammer milestone Nov 12, 2016
@smithfarm smithfarm changed the title hammer: Ceph Status - Segmentation Fault hammer: cephx: Fix multiple segfaults due to attempts to encrypt or decrypt Nov 16, 2016
smithfarm added a commit that referenced this pull request Nov 18, 2016
…to attempts to encrypt or decrypt

Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm added a commit that referenced this pull request Nov 20, 2016
…to attempts to encrypt or decrypt

Reviewed-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

@tchaikov @badone This backport passed a rados suite at http://tracker.ceph.com/issues/17151#note-7 with failures that I believe have been addressed (except for http://tracker.ceph.com/issues/15139 which is caused by the build system no longer providing dumpling-era packages).

I have rebuilt the integration branch to include the two fixes and scheduled a new run at http://tracker.ceph.com/issues/17151#note-14

Do you think it's OK to merge provided the second run succeeds?

@badone
Copy link
Contributor

badone commented Nov 20, 2016

Hey @smithfarm, thsnkd for working on this. I don't think any of the failures are directly related to this patch right? If they are unrelated I don't see any reason why we can't merge.

@smithfarm
Copy link
Contributor Author

@badone Right, the failures are not related to this PR.

smithfarm added a commit that referenced this pull request Nov 21, 2016
…to attempts to encrypt or decrypt

Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm added a commit that referenced this pull request Nov 21, 2016
…to attempts to encrypt or decrypt

Reviewed-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

@tchaikov
Copy link
Contributor

@smithfarm lgtm.

@tchaikov tchaikov removed their assignment Nov 21, 2016
@smithfarm smithfarm merged commit af6e208 into ceph:hammer Nov 23, 2016
@smithfarm smithfarm deleted the wip-17346-hammer branch November 23, 2016 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants