hammer: rgw: fix inconsistent uid/email handling in radosgw-admin #11952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the email address inconsistency documented in upstream Ceph BUG ceph#13598 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 4c438db)
Fixes the error return inconsistency documented in upstream Ceph issue ceph#13598 Revised after upstream review, permits changing email address as originally (but use case-insensitive comp). Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 90c143e) Conflicts: src/rgw/rgw_user.cc (there is no op_state.found_by_email conditional in hammer)
smithfarm
changed the title
smithfarm
added a commit
that referenced
this pull request
Nov 18, 2016
…ndling in radosgw-admin Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Nov 20, 2016
…ndling in radosgw-admin Reviewed-by: Nathan Cutler <ncutler@suse.com>
|
@oritwas This PR was tested by rgw suite as described here: http://tracker.ceph.com/issues/17151#note-11 All tests passed except one that failed with "saw valgrind issues" - see http://pulpito.front.sepia.ceph.com/smithfarm-2016-11-18_10:00:20-rgw-hammer-backports---basic-smithi/558612/ Do you think this PR is OK to merge? Also, can you help debug that failed test? |
|
@oritwas I looked at the failed test and described my analysis in http://tracker.ceph.com/issues/17151#note-11 ( it looks like a case of http://tracker.ceph.com/issues/13529 ) |
|
lgtm |
smithfarm
added a commit
that referenced
this pull request
Nov 21, 2016
…ndling in radosgw-admin Reviewed-by: Nathan Cutler <ncutler@suse.com>
smithfarm
added a commit
that referenced
this pull request
Nov 21, 2016
…ndling in radosgw-admin Reviewed-by: Nathan Cutler <ncutler@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16318