New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050
Conversation
Fixes: http://tracker.ceph.com/issues/16180 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Post-Kraken feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect the new librados test stub functions were a part of the librados commit (not librbd commit). Otherwise lgtm.
[DNM] librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050
[DNM] librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050
[DNM] librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dillaman I thinks DNM can be removed? |
@trociny I'd prefer to wait until Kraken is released and we are 100% sure the kraken branch won't be rebased to master. |
[DNM] librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050
@ceph-jenkins retest this please |
No description provided.