Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050

Merged
merged 2 commits into from Jan 5, 2017

Conversation

dillaman
Copy link

No description provided.

Jason Dillaman added 2 commits November 17, 2016 12:07
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@dillaman
Copy link
Author

Post-Kraken feature

Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect the new librados test stub functions were a part of the librados commit (not librbd commit). Otherwise lgtm.

trociny pushed a commit that referenced this pull request Nov 28, 2016
[DNM] librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050
trociny pushed a commit that referenced this pull request Dec 2, 2016
[DNM] librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050
trociny pushed a commit that referenced this pull request Dec 8, 2016
[DNM] librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trociny
Copy link
Contributor

trociny commented Dec 14, 2016

@dillaman I thinks DNM can be removed?

@dillaman
Copy link
Author

@trociny I'd prefer to wait until Kraken is released and we are 100% sure the kraken branch won't be rebased to master.

trociny pushed a commit that referenced this pull request Dec 15, 2016
[DNM] librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs #12050
@dillaman dillaman changed the title [DNM] librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs librados: asynchronous selfmanaged_snap_create/selfmanaged_snap_remove APIs Jan 4, 2017
@trociny
Copy link
Contributor

trociny commented Jan 5, 2017

@ceph-jenkins retest this please

@trociny trociny merged commit 18567fb into ceph:master Jan 5, 2017
@dillaman dillaman deleted the wip-16180 branch January 5, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants