Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/rgw_main.cc: fix parenteses and function result #12295

Merged
merged 1 commit into from Feb 21, 2017

Conversation

wjwithagen
Copy link
Contributor

  • The function in the macro parameter is expected to return -1 i
    on error and not type(bool).
    So reorganize the parenteses and just pass dup2() to the macro.

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

 - The function in the macro parameter is expected to return -1 i
   on error and not type(bool).
   So reorganize the parenteses and just pass dup2() to the macro.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen
Copy link
Contributor Author

@tchaikov
I guess that this needs to run thru QA as well?
The change is minute, and should not trip anything. But you never know

Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwithagen
Copy link
Contributor Author

@tchaikov
Would you care looking at this one as well?

@tchaikov tchaikov self-assigned this Jan 4, 2017
@tchaikov
Copy link
Contributor

@wjwithagen it's just pending on a rgw qa run.

@tchaikov
Copy link
Contributor

@mattbenjamin could you include this PR in your next batch of qa run?

@wjwithagen
Copy link
Contributor Author

@mattbenjamin
Could you have a look at this?
Not going to say it is trivial, but then again it is not real complex either

@wjwithagen
Copy link
Contributor Author

@tchaikov @mattbenjamin
Any particulars why this cannot be merged?

@tchaikov tchaikov merged commit 4454340 into ceph:master Feb 21, 2017
@wjwithagen
Copy link
Contributor Author

@tchaikov
Thanx

@wjwithagen wjwithagen deleted the wip-wjw-TEMP_FAILURE branch February 21, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants