Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: multisite: failed assertion in 'radosgw-admin bucket sync status' #12314

Merged
merged 1 commit into from Feb 1, 2017
Merged

jewel: rgw: multisite: failed assertion in 'radosgw-admin bucket sync status' #12314

merged 1 commit into from Feb 1, 2017

Conversation

ghost
Copy link

@ghost ghost commented Dec 5, 2016

RGWBucketSyncStatusManager was creating its own RGWAsyncRadosProcessor
and failing to clean it up on destruction. A recent change turned
global_init()'s return value into an intrusive_ptr to guarantee that our
CephContext is freed, and this triggered an assertion that all worker
threads were shut down

Fixes: http://tracker.ceph.com/issues/18083

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 3ad2c2a)
@ghost ghost self-assigned this Dec 5, 2016
@ghost ghost added this to the jewel milestone Dec 5, 2016
@ghost ghost added bug-fix rgw labels Dec 5, 2016
ghost pushed a commit that referenced this pull request Dec 5, 2016
…osgw-admin bucket sync status'

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost changed the base branch from jewel-next to jewel December 21, 2016 23:25
@ghost
Copy link
Author

ghost commented Dec 21, 2016

check this please

@smithfarm smithfarm merged commit 4cbe0e3 into ceph:jewel Feb 1, 2017
@smithfarm
Copy link
Contributor

@smithfarm smithfarm changed the title jewel: multisite: failed assertion in 'radosgw-admin bucket sync status' jewel: rgw: multisite: failed assertion in 'radosgw-admin bucket sync status' Feb 1, 2017
@smithfarm
Copy link
Contributor

(11:46:45 AM) smithfarm: owasserm: thanks. For jewel integration rgw, then, what it comes down to is verifying that these 6 valgrind failures are all libtcmalloc-related: http://pulpito.front.sepia.ceph.com/smithfarm-2017-01-31_12:35:14-rgw-wip-jewel-backports-distro-basic-smithi/
(11:46:58 AM) smithfarm: owasserm: I will do that now
(11:47:05 AM) owasserm: smithfarm, thanks
(11:47:33 AM) smithfarm: owasserm: and assuming they are tcmalloc related, you said I can directly merge all the rgw PRs? Or do you want me to ask you for review in the PRs first?
(11:47:53 AM) owasserm: smithfarm, yes you can merge them
(11:48:19 AM) smithfarm: ok, will merge and do at least one or two more rgw runs before passing 10.2.6 to QE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants