doc: Update CephFS disaster recovery documentation #12370
Conversation
|
@jcsp Could you take a look at this one? |
|
@jcsp Could you take a look at this one? |
| @@ -32,14 +32,16 @@ void DataScan::usage() | |||
| { | |||
| std::cout << "Usage: \n" | |||
| << " cephfs-data-scan init [--force-init]\n" | |||
| << " cephfs-data-scan scan_extents [--force-pool] <data pool name>\n" | |||
| << " cephfs-data-scan scan_inodes [--force-pool] [--force-corrupt] <data pool name>\n" | |||
| << " cephfs-data-scan scan_extents [--force-pool] [--worker_n N --worker_m M] <data pool name>" << dendl; | |||
There was a problem hiding this comment.
The replacement of "\n" with "<< dendl;" is incorrect here (and does not compile)
There was a problem hiding this comment.
Sure? It compiled I thought and the tests say so. I will change it anyway.
|
@wido wow, did I really leave this for so long? Sorry! |
wido
force-pushed
the
docs-cephfs-disaster
branch
from
428c458
to
67e3017
Compare
|
@jcsp No problem! How does this look now? |
| @@ -33,14 +33,16 @@ void DataScan::usage() | |||
| { | |||
| std::cout << "Usage: \n" | |||
| << " cephfs-data-scan init [--force-init]\n" | |||
| << " cephfs-data-scan scan_extents [--force-pool] <data pool name>\n" | |||
| << " cephfs-data-scan scan_inodes [--force-pool] [--force-corrupt] <data pool name>\n" | |||
| << " cephfs-data-scan scan_extents [--force-pool] [--worker_n N --worker_m M] <data pool name>" << std::endl; | |||
There was a problem hiding this comment.
This whole section is one statement, like std::cout << A << B << C;
What you're changing it to is something like std::cout << A << B << std::endl; << C;, it doesn't make sense.
You could do it by using std::endl and a trailing "<<" instead of ";", but really I'd just use "\n" like the original code.
|
The reason it looks like it compiles is that the checks that run on PRs are the unit tests: they don't actually build the whole tree (maybe we should change that) |
Better documentation about spawning multiple workers to speed up the recovery proces. Signed-off-by: Wido den Hollander <wido@42on.com>
wido
force-pushed
the
docs-cephfs-disaster
branch
from
67e3017
to
d0c8d8c
Compare
|
@jcsp: Argh, dôh. Compiling takes such a time on my systems that you sometimes look at the code only. Fixed now. |
|
@jcsp: Small ping again? ;) |
Better documentation about spawning multiple workers to speed
up the recovery proces.
Signed-off-by: Wido den Hollander wido@42on.com