os/filestore/HashIndex: be loud about splits #12421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cernceph Could you open a tracker issue for this? You can flag the issue for jewel backport while doing that, just fill in Backport: jewel. If you open the tracker, please also add a line |
|
I would use dout(1) instead of dout(0) (which will also go to the log by default). Otherwise, LGTM! |
liewegas
requested changes
Dec 12, 2016
Filestore splits are a rare yet important enough event that an OSD should visibly report when they happen. Without this reporting an operator could spend hours trying to understand the cause of any split-induced slow requests. Fixes: http://tracker.ceph.com/issues/18235 Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
cernceph
force-pushed
the
wip-dvanders-split
branch
from
672f607
to
61c47ac
Compare
liewegas
approved these changes
Feb 28, 2017
liewegas
changed the title
|
RADOS http://pulpito.ceph.com/yuriw-2017-03-02_01:20:35-rados-wip-yuri-testing_2017_3_2---basic-smithi/ and reproduce http://pulpito.ceph.com/yuriw-2017-03-02_01:56:48-rados-wip-yuri-testing_2017_3_2---basic-ovh/ same job passed on manual rerun ! and confirmed pass RBD TestLibRBD.FlattenNoEmptyObjects failures unrelated, also on master per @jasondillaman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ML thread "[ceph-users] filestore_split_multiple hardcoded maximum" has coincided with ~1 week of slow requests on one of our clusters. After much debugging we finally tracked it down to filestore splitting.
It would have been much easier to understand the root cause if filestore splitting was verbose. Splitting is a rare but rather important event -- the OSD should be super verbose when it happens. (Otherwise, it simply looks like a filestore write is taking many 10s of seconds, which seems absurd).
So I'm sending this patch for comments. I'm not sure if the dout is needed in the _create function, and I didn't make the merges verbose yet (which I guess is also needed?)
If this makes it to master, I'd appreciate a backport to jewel. (filestore will lose relevance anyway in L and beyond).