Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: add option to log custom HTTP headers (rgw_log_http_headers) #12490

Merged
3 commits merged into from Feb 15, 2017

Conversation

mattbenjamin
Copy link
Contributor

@mattbenjamin mattbenjamin commented Dec 14, 2016

@liewegas liewegas added this to the jewel milestone Dec 29, 2016
@ghost ghost changed the base branch from jewel-next to jewel January 12, 2017 06:34
@ghost ghost changed the title jewel: rgw: add option to log custom HTTP headers (rgw_log_http_headers) DNM: jewel: rgw: add option to log custom HTTP headers (rgw_log_http_headers) Jan 12, 2017
@ghost
Copy link

ghost commented Jan 12, 2017

@mattbenjamin could you please amend the commit messages to explain why these cannot be cherry-picked from master ? If they are cherry-picked from master, could you update them with git cherry-pick -x so that they reference the original commit SHA ? Thanks !

@mattbenjamin
Copy link
Contributor Author

mattbenjamin commented Jan 12, 2017

@dachary sure--yes, it cannot be trivially cherry-picked--well, it can in part; the use of std::map and removal of related changes due to that is the reason

Tracks headers that should be handled conditionally (currently,
can only log, so using minimal structure to represent the
mapping).

Adds map of custom headers to rgw_log_entry, and populate it with
headers pre-selected for custom logging in RGWREST.  Added to encoder
and Formatter output.

Some additional optimization possible.

(cherry picked from commit b82919a)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(adaptation commit for ceph#7639)

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Explain the option for upstream doc.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 04bf0f8)
@mattbenjamin
Copy link
Contributor Author

@dachary ok, done; waiting for build checks

@mattbenjamin mattbenjamin changed the title DNM: jewel: rgw: add option to log custom HTTP headers (rgw_log_http_headers) jewel: rgw: add option to log custom HTTP headers (rgw_log_http_headers) Feb 8, 2017
@ghost ghost self-assigned this Feb 13, 2017
@ghost
Copy link

ghost commented Feb 15, 2017

It passed the rgw suite at http://tracker.ceph.com/issues/17851#note-66.

@ghost ghost merged commit 3192ef6 into ceph:jewel Feb 15, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants