Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd, messenger, librados: lttng oid tracing #12492

Merged
merged 2 commits into from Jan 18, 2017
Merged

osd, messenger, librados: lttng oid tracing #12492

merged 2 commits into from Jan 18, 2017

Conversation

yehudasa
Copy link
Member

This PR is a cleaned up version of #12330

@liewegas liewegas mentioned this pull request Dec 16, 2016
Closed
@liewegas
Copy link
Member

[ 22%] Building CXX object src/tools/rbd_mirror/CMakeFiles/rbd_mirror_internal.dir/image_replayer/CreateImageRequest.cc.o
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/EventTrace.cc:29:32: fatal error: tracing/eventtrace.h: No such file or directory
#include "tracing/eventtrace.h"
^
compilation terminated.

@rchagam
Copy link
Contributor

rchagam commented Dec 20, 2016

This is missing one additional commit e1f2333 from prior pull request #12330. I have made one additional change to track BlueStore events - would like to push this to yehudasa/wip-func-oid-tracing branch if I can get access to push.

@rchagam
Copy link
Contributor

rchagam commented Dec 20, 2016

https://github.com/rchagam/ceph/tree/wip-func-oid-tracing has all the changes too

@yehudasa
Copy link
Member Author

@rchagam does that also fix this build failure? #12492 (comment)

@yehudasa
Copy link
Member Author

@rchagam I now see this commit:
rchagam@3590b16

So which one do we need to apply?

@yehudasa
Copy link
Member Author

retest this please

@liewegas
Copy link
Member

Needs rebase

@rchagam
Copy link
Contributor

rchagam commented Jan 3, 2017

Rebased, changed to new ceph_clock_now() function and tested. Pl pull in all files from https://github.com/rchagam/ceph/tree/wip-func-oid-tracing (commit: 5899e99). I will test your branch once you merge my latest commit files.

@rchagam @yehudasa
common: extend lttng tracing infrastructure
b3b2044 
New function and oid lttng tracing enhancements that provide function
and oid level latency breakdown. Requires WITH_EVENTTRACE=ON option to enable.

Signed-off-by: Anjaneya Chagam <anjaneya.chagam@intel.com>
@rchagam @yehudasa
osd, messenger, librados: lttng enhancements
b7b14ad 
Few critical functions have been instrumented with function tracing
and oid tracing calls to help routing performance analysis.
Oid tracing events are heavily dependent on functional changes and may need
to be revised as and when core data flow logic changes.

Signed-off-by: Anjaneya Chagam <anjaneya.chagam@intel.com>
@yehudasa
Copy link
Member Author

@rchagam I pushed a new version, can you look at it, make sure that everything is in?

@rchagam
Copy link
Contributor

rchagam commented Jan 18, 2017

@yehudasa tested with and without tracing enabled and everything is good to go.
Thx a lot for your help.

@yehudasa yehudasa merged commit 5c5147e into ceph:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
3 participants
@yehudasa @liewegas @rchagam