Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jewel: rbd: librbd: use proper snapshot when computing diff parent overlap #12649

Merged
merged 1 commit into from Jan 30, 2017
Merged

jewel: rbd: librbd: use proper snapshot when computing diff parent overlap #12649

merged 1 commit into from Jan 30, 2017

Conversation

xiaoxichen
Copy link
Contributor

@xiaoxichen
librbd/diff_iterator: use proper snap to query parent overlap
64c0cae 
If no snapshot has been made, we will use CEPH_NOSNAP instead of 0,
to query the parent overlap.

Fixes bug http://tracker.ceph.com/issues/18200

Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
(cherry picked from commit a88ceff)
@xiaoxichen xiaoxichen self-assigned this Dec 23, 2016
@xiaoxichen xiaoxichen added this to the jewel milestone Dec 23, 2016
@xiaoxichen
Copy link
Contributor Author

@smithfarm , would you mind add this PR to testing?

@xiaoxichen xiaoxichen changed the title jewel: RBD diff got SIGABRT with --whole-object for RBD whose parent also have fast-diff feature enabled. jewel: librbd: use proper snapshot when computing diff parent overlap Jan 16, 2017
@smithfarm
Copy link
Contributor

@dillaman This PR passed an RBD suite at http://tracker.ceph.com/issues/17851#note-41
with a single failure [1] that was not reproducible in a subsequent run.

[1] The failure was a reoccurrence of http://tracker.ceph.com/issues/17695
which was supposed to have been fixed in jewel by #11644

dillaman
dillaman approved these changes Jan 30, 2017
View reviewed changes
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smithfarm smithfarm changed the title jewel: librbd: use proper snapshot when computing diff parent overlap jewel: rbd: librbd: use proper snapshot when computing diff parent overlap Jan 30, 2017
@smithfarm smithfarm merged commit efad365 into ceph:jewel Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillaman dillaman dillaman approved these changes

@smithfarm smithfarm Awaiting requested review from smithfarm

Assignees

@xiaoxichen xiaoxichen

Labels
bug-fix core
Projects
None yet
Milestone
jewel
3 participants
@xiaoxichen @smithfarm @dillaman