New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update test_rados_tool.sh, use POOL and OBJ var #12706
Conversation
# clean up environment, delete pool | ||
$CEPH_TOOL osd pool delete $POOL $POOL --yes-i-really-really-mean-it | ||
$CEPH_TOOL osd pool delete $POOL_EC $POOL_EC --yes-i-really-really-mean-it | ||
$CEPH_TOOL osd pool delete $POOL_CP_TARGE $POOL_CP_TARGET --yes-i-really-really-mean-it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/POOL_CP_TARGE/POOL_CP_TARGET/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thanks.
by the way, it seems that "ceph osd pool delete" will always returns 0 whether it's successfully or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i have tried it.
ceph returns 0 if pool isn't exist.
ceph returns 1 if pool1 != pool2 and pool1 exists.
ce16846
to
16de87d
Compare
then | ||
die "Append failed expecting $orig_size read $read_size" | ||
fi | ||
$RADOS_TOOL -p $POOL append $OBJ ./rados_append_4k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this changes the behavior of this test. prior to this change, we
- create an empty object
- append 4k "0" blob to it
- compare it with the 4k blob
after this change
- append 4k "0" blob to a non-exisitent object
- compare it with the 4k blob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. very thanks for your review
16de87d
to
24eb303
Compare
Test this please |
@@ -267,7 +271,7 @@ done | |||
run_expect_nosignal "$RADOS_TOOL" --pool "$POOL" bench 1 rand | |||
run_expect_nosignal "$RADOS_TOOL" --pool "$POOL" bench 1 seq | |||
|
|||
set -e | |||
set -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, I have squashed commits. thanks tchaikov
* replace hard-code pool name with $POOL * replace hard-code object name with $OBJ * introduce a new variable called $POOL_EC * clean up pool * simplify test case Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
1429b28
to
96f5c92
Compare
@tchaikov ping |
ref to #12674
@tchaikov @liewegas
Signed-off-by: liuchang0812 liuchang0812@gmail.com