os/bluestore/BitmapFreelistManager: readability improvements #12719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep pace with other private methods. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-1229
branch
from
825275c
to
b11b169
Compare
liewegas
requested changes
Dec 30, 2016
| @@ -113,33 +113,32 @@ int BitmapFreelistManager::init() | |||
|
|
|||
| // load meta | |||
| while (it->valid()) { | |||
| string k = it->key(); | |||
| if (k == "bytes_per_block") { | |||
| if (it->key() == "bytes_per_block") { | |||
There was a problem hiding this comment.
key() returns a string by value, not reference, so c_str() here is a use-after-free
xiexingguo
force-pushed
the
xxg-wip-bluestore-1229
branch
from
b11b169
to
d2d4ed9
Compare
|
retest this please |
liewegas
reviewed
Jan 11, 2017
| if (p[byte] & mask) { | ||
| int which_byte = start / 8; | ||
| int which_bit = start % 8; | ||
| if (p[which_byte] & byte_bit_mask[which_bit]) { |
There was a problem hiding this comment.
is this really better than 1 << which_bit ?
There was a problem hiding this comment.
I doubt.
Repushed, can you check again?
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-1229
branch
2 times, most recently
from
28b0011
to
ea5d71c
Compare
Be slightly nice to who is looking at get_next_clear[set]_bit(). Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@liewegas Any more comments? |
liewegas
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.