Move code from .h into .cc #12737
Merged
Move code from .h into .cc #12737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amir Vadai <amir@vadai.me>
Signed-off-by: Amir Vadai <amir@vadai.me>
Infiniband.cc: In member function ‘int Infiniband::recv_msg(CephContext*, int, IBSYNMsg&)’:
Infiniband.cc:883:86: warning: format ‘%x’ expects argument of type ‘unsigned int*’, but argument 3 has type ‘uint16_t* {aka short unsigned int*}’ [-Wformat=]
sscanf(msg, "%x:%x:%x:%x:%s", &(im.lid), &(im.qpn), &(im.psn),
&(im.peer_qpn),gid);
Signed-off-by: Amir Vadai <amir@vadai.me>
|
Adding @Adirl |
|
@yuyuyu101 pls take a look |
|
hmm, it's ok to me.. but I don't why we need to move all tiny implementation to .cc? |
|
Thanks @yuyuyu101 I moved only multiline functions to the .cc |
Adirl
approved these changes
Jan 4, 2017
yuyuyu101
approved these changes
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request has some cosmetic changes to the RDMA code.
It has only copy-paste stuff (Except the last small patch) to make it easy to review.
last patch fixes a warning which is actually a small bug.
Thanks,
Amir