client: Fix lookup of "/.." in jewel #12766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CEPH_INO_DOTDOT thing is quite strange. Under most OS (Linux included), the parent of the root is itself. IOW, at the root, '.' and '..' refer to the same inode. Change the ceph client to do the same, as this allows users to get valid stat info for '..', as well as elimnating some special-casing. Also in several places, we're checking dn_set.empty as an indicator of being the root. While that is true for the root, it's also true for unlinked directories. This patch has treats them the same. An unlinked directory will be reparented to itself, effectively acting as a root of its own. Fixes: http://tracker.ceph.com/issues/18408 Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit 30d4ca0)
|
Test run here mostly passed with a few failures that look unrelated to this: http://pulpito.ceph.com/jlayton-2017-01-03_20:28:20-fs-wip-18408-jewel---basic-smithi/ |
jtlayton
force-pushed
the
wip-18408-jewel
branch
from
89a7809
to
95edad2
Compare
|
Not sure why the build failed there. Looks like something fell over in jenkins? The patch itself doesn't break anything in my testing. |
|
Jenkins test this please |
|
Assigning @gregsfortytwo and @jcsp to review. This should be harmless in jewel, but let me know if you have any objections. |
ukernel
approved these changes
Jan 9, 2017
gregsfortytwo
approved these changes
Jan 9, 2017
liewegas
changed the title
|
@ukernel This passed a cephfs run here [1] with a few failures that appear unrelated to the PR. OK to merge? [1] #12766 (comment) |
|
oh, I see @ukernel already approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a problem for nfs-ganesha when built against libcephfs. Currently with the jewel client, doing a lookup of ".." at the root directory ends up returning -ENOENT. This converts it to consider the parent of the root to be the root itself (similarly to how /.. works in Linux).
Only lightly tested so far but it is building now and I'll run the whole fs suite over it once it's done.