cmake: remove Findpciaccess.cmake #12776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
requested changes
Jan 4, 2017
| target_include_directories(os | ||
| PRIVATE | ||
| ${DPDK_INCLUDE_DIR} | ||
| ${PCIACCESS_INCLUDE_DIR}) | ||
| ${DPDK_INCLUDE_DIR}) |
There was a problem hiding this comment.
then you might need to remove find_package(pciaccess REQUIRED) in CMakeLists.txt and #include <pciaccess.h> in NVMEDevice.h as well.
There was a problem hiding this comment.
Let me update it
tchaikov
changed the title
optimistyzy
force-pushed
the
201714
branch
2 times, most recently
from
8e39913
to
f4c3167
Compare
Now SPDK uses the DPDK's library for PCI device enumeration, we can remove this dependency Signed-off-by: optimistyzy <optimistyzy@gmail.com>
tchaikov
approved these changes
Jan 4, 2017
|
lgtm too. |
liupan1111
approved these changes
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now SPDK uses the DPDK's library for PCI device
enumeration, we can remove this dependency
Signed-off-by: optimistyzy optimistyzy@gmail.com