jewel: Decode errors on backtrace will crash MDS #12836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2017 14:58
Fixes: http://tracker.ceph.com/issues/18311 Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 6f489c7)
Validate that we get EIO and a damage table entry when seeing a decode error on a backtrace. Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 5f6cdab)
|
The test in this one had a dependency on this earlier test commit: That was part of the PR to add backtrace repairs during forward scrub, which is not a bugfix so I'd skip backporting it. I think the thing to do here is to copy-paste the _write_data_xattr function from that PR into a separate commit in this PR. |
|
@jcsp Done, but I guess it doesnt warrant a separate commit - better would be to squash the commit into the qa/tasks cherry-pick and write a note about it in Conflicts:, do you agree? |
|
@jcsp Oh, now I see you specifically said you wanted a separate commit. So, here it is. |
This is a partial manual backport of 5f77f09 It is needed by test_corrupt_backtrace() in qa/tasks/cephfs/test_damage.py Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm
force-pushed
the
wip-18462-jewel
branch
from
2bafcf9
to
85fbddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18462