rbd: bench-write should return error if io-size >= 4G #12864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
reviewed
Jan 10, 2017
| @@ -196,6 +196,10 @@ int do_bench(librbd::Image& image, io_type_t io_type, | |||
| return -EINVAL; | |||
| } | |||
|
|
|||
| if (io_size > 4294967295) { | |||
There was a problem hiding this comment.
Nit: if (io_size > 0xFFFFFFFF) is more readable
There was a problem hiding this comment.
thank you :), will do it in next PR
There was a problem hiding this comment.
Even better -- or the C++ std::numeric_limits<uint32_t>::max()
There was a problem hiding this comment.
yeah, std::numeric_limits<uint32_t>::max() is better. will use in next PR
dillaman
reviewed
Jan 10, 2017
| @@ -196,6 +196,10 @@ int do_bench(librbd::Image& image, io_type_t io_type, | |||
| return -EINVAL; | |||
| } | |||
|
|
|||
| if (io_size > 4294967295) { | |||
| std::cerr << "rbd: io-size should be less than 4G" << std::endl; | |||
There was a problem hiding this comment.
Nit: ... should not exceed 4G since it can be <=
There was a problem hiding this comment.
it can be < but i can not be <=, because 4G is overflowing. 4G=4294967296 and after overflow value (unsigned l) will become 0. so i think io-size should be less than 4G
Currently if user perform bench-write with io-size > 4G then its crashing because currently during memory allocation bufferptr taking size of buffer as a unsigned and io-size > 4G will overflow with unsigned. so during memset operation it will try to set io_size size of memory area pointed by bufferptr, (bufferptr area is: (4G - io_size)), so it will cause segmentation fault. Fix is to return error if io-size >= 4G Fixes: http://tracker.ceph.com/issues/18422 Reported-by: Jason Dillaman <dillaman@redhat.com> Signed-off-by: Gaurav Kumar Garg <garg.gaurav52@gmail.com>
gaurav36
force-pushed
the
bug-18422-rbd-bench-write-crash-4G-io-size
branch
from
3201c12
to
6ab73e5
Compare
dillaman
approved these changes
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if user perform bench-write with io-size > 4G
then its crashing because currently during memory allocation
bufferptr taking size of buffer as a unsigned and io-size > 4G
will overflow with unsigned. so during memset operation it will
try to set io_size size of memory area pointed by bufferptr,
(bufferptr area is: (4G - io_size)), so it will cause
segmentation fault.
Fix is to return error if io-size >= 4G
Fixes: http://tracker.ceph.com/issues/18422
Reported-by: Jason Dillaman dillaman@redhat.com
Signed-off-by: Gaurav Kumar Garg garg.gaurav52@gmail.com