Jewel: speed up readdir by skipping unwanted dn #12921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can skip unwanted dn which < (offset_key, snap) via map.lower_bound, rather than iterate across them. Previously we iterate and skip dn which < (offset_key, dn->last), as dn->last >= snap means (offset_key, dn->last) >= (offset_key, snap), and such iterate_and_skip logic still keep, so this commit doesnt change code logic but an optimization. Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com> (cherry picked from commit 52fe52b)
xiaoxichen
added
bug-fix
core
cephfs
|
@smithfarm could we put this on your radar for next time you're building a backport test branch? |
|
@jcsp This backport PR is correctly staged, so it will be included. |
|
@jcsp This PR passed an fs suite at http://tracker.ceph.com/issues/17851#note-39 with some valgrind issues, some of which can be ignored because they occurred on tcmalloc builds. That said, there is one valgrind issue in the MDS which resembles http://tracker.ceph.com/issues/5241 (28 MDSCacheObject occurrences). Do you think this PR can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18520