New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mailmap: Willem Jan Withagen affiliation #13034
Conversation
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it's "mailmap: ". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another affiliation in organization map (for digiware) if it is a change of organization, you need an entry in peoplemap as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another affiliation in organization map (for digiware) if it is a change of organization, you need an entry in peoplemap as well
@theanalyst |
@wjwithagen ah ok, I assumed it was a change of companies, then it is ok, I believe we don't need an entry in the .peoplemap then, I also think the mailmap entry is not needed here and only the organizationmap would suffice, as otherwise all the digiware commits would show up as nefos, without the mailmap entry it would show up as two seperate organizations depending on the email, which is what you want. I could be wrong, I'll let @dachary confirm. |
I confirm. |
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
c52d7bc
to
07e0efe
Compare
Signed-off-by: Willem Jan Withagen wjw@digiware.nl