Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailmap: Willem Jan Withagen affiliation #13034

Merged
merged 1 commit into from Feb 14, 2017
Merged

Conversation

wjwithagen
Copy link
Contributor

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@tchaikov
Copy link
Contributor

tchaikov commented Feb 8, 2017

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it's "mailmap: ".

@tchaikov tchaikov changed the title Affiliation updates mailmap: Willem Jan Withagen affiliation Feb 8, 2017
Copy link
Member

@theanalyst theanalyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another affiliation in organization map (for digiware) if it is a change of organization, you need an entry in peoplemap as well

Copy link
Member

@theanalyst theanalyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another affiliation in organization map (for digiware) if it is a change of organization, you need an entry in peoplemap as well

@wjwithagen
Copy link
Contributor Author

@theanalyst
I actaully work for 2 companies: digiware and nefos.
Both are paying my bills currently.
Looking at the content of the organisationmap, it looks like there are more people in the same situation?

@theanalyst theanalyst requested a review from a user February 10, 2017 10:05
@theanalyst
Copy link
Member

@wjwithagen ah ok, I assumed it was a change of companies, then it is ok, I believe we don't need an entry in the .peoplemap then, I also think the mailmap entry is not needed here and only the organizationmap would suffice, as otherwise all the digiware commits would show up as nefos, without the mailmap entry it would show up as two seperate organizations depending on the email, which is what you want. I could be wrong, I'll let @dachary confirm.

@ghost
Copy link

ghost commented Feb 10, 2017

I confirm.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@liewegas liewegas merged commit 293c766 into ceph:master Feb 14, 2017
@wjwithagen wjwithagen deleted the wip-wjw-brag branch February 20, 2017 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants