#18600: Clear out tasks that don't make sense from multimds suite #13089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2017 23:25
...so that we can selectively disable those which are not appropriate for multimds testing, or which are not kclient compatible (all multimds workunits run against both kclient and fuse). Signed-off-by: John Spray <john.spray@redhat.com>
Quotas don't work with kclient, and multimds tasks are run against kclient. We don't need to run this against fuse here because it's a basic correctness test that's run against fuse in the fs suite. Fixes: http://tracker.ceph.com/issues/18600 Signed-off-by: John Spray <john.spray@redhat.com>
ukernel
approved these changes
Jan 25, 2017
|
My concern here is that it's an explicit mapping of what tests we want to run in multi-mds, which means we have to remember to opt-in when building new tests. |
|
I'm not motivated to add that feature to teuthology, because on the long run I'm not sure we're really going to maintain these as two side by side suites -- once multimds suite is stable and multi-mds systems are the norm, I'm imagining cutting the "fs" suite back to something more minimal, and all the real long running workload tests would run in multi-mds configurations. |
jcsp
changed the title
These were running so few ops that they weren't giving any meaningful exercise to a multimds system beyond what we're already covering in the fs suite. Signed-off-by: John Spray <john.spray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone a little further than just removing the quota, to also remove the very basic tests that it seems wasteful to run in the multimds suite as well as the fs suite