doc: Document that osd_heartbeat_grace applies to MON and OSD #13098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecluis
reviewed
Jan 25, 2017
| period by adding an ``osd heartbeat grace`` setting under the ``[osd]`` section | ||
| of your Ceph configuration file, or by setting the value at runtime. | ||
| period by adding an ``osd heartbeat grace`` setting under the ```[mon]``` | ||
| and ``[osd]`` section of your Ceph configuration file, or by setting the |
There was a problem hiding this comment.
setting in [global] will apply to both osds and mons, btw. Maybe worth mentioning that as well. Same for the description section in the other chunk of the patch.
|
Thanks @jecluis! I pushed a new version of the patch. Care to review? |
tchaikov
approved these changes
Jan 26, 2017
jdurgin
reviewed
Jan 28, 2017
| period by adding an ``osd heartbeat grace`` setting under the ``[osd]`` section | ||
| of your Ceph configuration file, or by setting the value at runtime. | ||
| period by adding an ``osd heartbeat grace`` setting under the ```[mon]``` | ||
| and ``[osd]`` or ```[global]```section of your Ceph configuration file, |
There was a problem hiding this comment.
triple backticks should only be double around [global] and [mon]
This value has to be set in both the [mon] and [osd] section since both daemons read this value. Signed-off-by: Wido den Hollander <wido@42on.com>
|
Thanks @jdurgin, updated commit pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value has to be set in both the [mon] and [osd] section since
both daemons read this value.
Signed-off-by: Wido den Hollander wido@42on.com