Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix broken async/rdma compilation since move to libceph-common #13122

Merged
merged 1 commit into from Jan 26, 2017

Conversation

orendu
Copy link

@orendu orendu commented Jan 26, 2017

Was broken since merge of pull request #12840

Signed-off-by: Oren Duer oren@mellanox.com

@orendu
Copy link
Author

orendu commented Jan 26, 2017

@tchaikov
Copy link
Contributor

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes. in this case, it would be "cmake: ".

@tchaikov
Copy link
Contributor

modulo the prefix of commit message title, lgtm

Was broken since merge of pull request ceph#12840

Signed-off-by: Oren Duer <oren@mellanox.com>
@tchaikov tchaikov merged commit 4755086 into ceph:master Jan 26, 2017
@tchaikov tchaikov self-assigned this Jan 26, 2017
@orendu orendu deleted the fix-rdma-compilation branch January 26, 2017 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants