Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: mds: fix MDSMap upgrade decoding #13139

Merged
2 commits merged into from Feb 15, 2017
Merged

jewel: mds: fix MDSMap upgrade decoding #13139

2 commits merged into from Feb 15, 2017

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Jan 26, 2017

batrick and others added 2 commits January 26, 2017 17:26
This reduces the number of code sites which modify standby_daemons.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 9566ae2)
Hammer MDSMonitors did not validate the state in beacons
and would apply anything to the mds_info_t for a standby,
such as setting it to down:dne.  We must handle this
case during upgrade.

Fixes: http://tracker.ceph.com/issues/17837
Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit a977c90)
@jcsp jcsp added bug-fix cephfs Ceph File System labels Jan 26, 2017
@jcsp jcsp requested a review from smithfarm January 26, 2017 17:29
@smithfarm
Copy link
Contributor

Ah, how easy the cherry-pick becomes when you cherry-pick the right other commit, first :-)

@jdurgin jdurgin added this to the jewel milestone Jan 28, 2017
@smithfarm
Copy link
Contributor

@jcsp This passed an fs suite at http://tracker.ceph.com/issues/17851#note-49 with 3 valgrind-related failures. OK to merge?

@oschulz
Copy link

oschulz commented Feb 11, 2017

Thanks you so much for this, @jcsp! This patch just saved our cluster, after upgrading from Hammer to Jewel.

@ghost ghost assigned smithfarm Feb 13, 2017
@smithfarm smithfarm changed the title jewel: src/mds: fix MDSMap upgrade decoding jewel: mds: fix MDSMap upgrade decoding Feb 13, 2017
@ghost
Copy link

ghost commented Feb 15, 2017

@ghost ghost merged commit cd9e5df into ceph:jewel Feb 15, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix cephfs Ceph File System
Projects
None yet
5 participants