rgw: don't log the env_map twice #13481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively we could keep this and drop the dout in |
|
@theanalyst if i had to choose, i'd keep the logging in |
|
@cbodley yeah makes sense in a way, also a little bit cleaner looking, (since we wouldn't have the various |
We currently log the client HTTP env vars twice, once while the env map is being set and second when the client_io is initiated, this commit avoids the redundant logging while setting the map Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
theanalyst
force-pushed
the
rgw/env-dout
branch
from
73672f8
to
f015186
Compare
|
@cbodley updated |
cbodley
approved these changes
Feb 17, 2017
theanalyst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already print the env_map during the
RGWEnv::setoperation,making this redundant
Signed-off-by: Abhishek Lekshmanan abhishek@suse.com