osd: remove copy-get-classic #13547
Merged
osd: remove copy-get-classic #13547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-kill-copy-get-classic
branch
from
eb4c9fb
to
f3ae439
Compare
tchaikov
approved these changes
Feb 21, 2017
| classic = true; | ||
| } | ||
| fill_in_copy_get_noent(op, oid, m->ops[0], classic); | ||
| (m->ops[0].op.op == CEPH_OSD_OP_COPY_GET)) { |
There was a problem hiding this comment.
could remove the parentheses around m->ops[0].op.op == CEPH_OSD_OP_COPY_GET.
|
I can't really imagine why someone would be using the 'copy-get-classic' rados op explicitly (vs 'copy-get'), but we can add it anyway! |
This hasn't been used since well before hammer. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-kill-copy-get-classic
branch
from
f3ae439
to
9076e69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hasn't been used since well before hammer.
Signed-off-by: Sage Weil sage@redhat.com