Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mds: add override in headers #13691

Merged
merged 1 commit into from Mar 8, 2017
Merged

mds: add override in headers #13691

merged 1 commit into from Mar 8, 2017

Conversation

liuchang0812
Copy link
Contributor

Signed-off-by: liuchang0812 liuchang0812@gmail.com

@tchaikov tchaikov added the cephfs Ceph File System label Mar 1, 2017
@batrick
Copy link
Member

batrick commented Mar 2, 2017

Can you explain how you generated this patch?

@jcsp
Copy link
Contributor

jcsp commented Mar 2, 2017

This has merge conflicts.

@liuchang0812
Copy link
Contributor Author

@batrick LLVM has a tool called clang-tidy, that it could do a lot of things base on semantic analyse. I use clang-tidy's clang-tidy -checks="-*, modernize-use-override" a.cpp -- -std=c++11 commond to add override automatically.

@jcsp Roger that, I will rebase it.

@liuchang0812 liuchang0812 force-pushed the wip-add-override-in-mds-headers branch from ca80111 to c285f30 Compare March 3, 2017 03:23
@liuchang0812
Copy link
Contributor Author

change log:

  1. rebased forward to master

@batrick
Copy link
Member

batrick commented Mar 3, 2017

@liuchang0812 thanks for explaining. Can you add a note about that to the commit message for posterity. Thanks.

@liuchang0812
Copy link
Contributor Author

@batrick roger that, I will add explaining to commit message soon

@liuchang0812
mds: add override in headers
1a91aea 
LLVM has a tool called clang-tidy, that it could do a lot of things base on
semantic analyse.  We could use following command to add override automatically:
clang-tidy -checks="-*, modernize-use-override" a.cpp -- -std=c++11

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
@liuchang0812 liuchang0812 force-pushed the wip-add-override-in-mds-headers branch from c285f30 to 1a91aea Compare March 3, 2017 07:29
@liuchang0812
Copy link
Contributor Author

change log:

  1. add note about clang-tidy in commit message

@liuchang0812
Copy link
Contributor Author

@batrick @jcsp hi, would you mind taking a look?

@batrick
Copy link
Member

batrick commented Mar 6, 2017

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@liuchang0812
Copy link
Contributor Author

@batrick @jcsp thanks. It would be better to merge it as soon as possible, because it contains a lot of changes and conflicts with other patches easily.

@jcsp jcsp merged commit 2a06ea3 into ceph:master Mar 8, 2017
@liuchang0812 liuchang0812 mentioned this pull request Mar 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick approved these changes

Assignees
No one assigned
Labels
cephfs Ceph File System cleanup
Projects
None yet
Milestone
No milestone
5 participants
@liuchang0812 @batrick @jcsp @tchaikov @liewegas