Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: if user.email is empty, dont try to delete #13783

Merged
merged 2 commits into from Mar 6, 2017

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Mar 3, 2017

rgw_delete_user() was attempting to delete the email index object even if the user's email address was empty. this was causing the osds to issue a cluster warning about bad locator @9 on object @9... and led to many teuthology failures

rgw_delete_user() now uses rgw_remove_email_index(), which has a new check for empty email address

RGWRados::delete_system_obj() also has a new check for empty object name, which it will reject immediately with -EINVAL to catch any other related issues

Fixes: http://tracker.ceph.com/issues/18980

Fixes: http://tracker.ceph.com/issues/18980

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Copy link
Member

@yehudasa yehudasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cbodley
Copy link
Contributor Author

cbodley commented Mar 6, 2017

teuthology results with no bad locator failures

@yehudasa yehudasa merged commit 452be3d into ceph:master Mar 6, 2017
@cbodley cbodley deleted the wip-18980 branch March 6, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants