osd: fix a signed/unsigned warning in PG #13922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nice if the stats were unsigned, since they can't go negative, but that's not the world we live in. (Also, we probably use these structures as deltas which *do* need to go negative? I didn't check.) Signed-off-by: Greg Farnum <gfarnum@redhat.com>
|
Didn't do any real testing of this, but it removed a signed/unsigned warning when compiled. |
liewegas
approved these changes
Mar 10, 2017
|
fwiw the stats are deliberately signed so that underflow is more graceful. |
|
I broke the submodule check |
|
retest this please |
1 similar comment
|
retest this please |
|
Did this not get through an integration branch yet? Just noticed I still needed to carry the patch through a rebase. |
|
@gregsfortytwo what is the ticket number? |
|
I don't think there was one. Just something that popped up when building. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if the stats were unsigned, since they can't go negative,
but that's not the world we live in.
(Also, we probably use these structures as deltas which do
need to go negative? I didn't check.)
Signed-off-by: Greg Farnum gfarnum@redhat.com