Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/volumes: unregister job upon async threads exception #33569

Merged
merged 1 commit into from Feb 27, 2020

Conversation

vshankar
Copy link
Contributor

If the async threads hit a temporary exception the job is
never unregistered and therefore gets skipped by the async
threads on subsequent scans.

Patrick hit this in nautilus when one of the purge threads
hit an exception when trying to log a message. The trash
entry was never picked up again by the purge threads.

Fixes: http://tracker.ceph.com/issues/44315
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 46476ef)
@vshankar vshankar added the cephfs Ceph File System label Feb 27, 2020
@vshankar vshankar added this to the nautilus milestone Feb 27, 2020
@vshankar
Copy link
Contributor Author

(building now -- will post the run link when done)

@vshankar
Copy link
Contributor Author

vshankar commented Feb 27, 2020

http://pulpito.ceph.com/vshankar-2020-02-27_10:27:36-fs-wip-vshankar-nautilus-2020-02-26-234924-testing-basic-smithi/

(rescheduled with a much lower priority)

EDIT: lower value, higher priority ;P

@batrick
Copy link
Member

batrick commented Feb 27, 2020

Failures are https://tracker.ceph.com/issues/44276

@batrick batrick merged commit 2885574 into ceph:nautilus Feb 27, 2020
@vshankar vshankar deleted the wip-44315 branch February 28, 2020 04:13
@it-is-a-robot it-is-a-robot mentioned this pull request Dec 20, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System
Projects
None yet
3 participants