tests: force checkout of submodules #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating submodules, always checkout even if the HEAD is the
desired commit hash (update --force) to avoid the following:
* a directory gmock exists in hammer
* a submodule gmock replaces the directory gmock in master
* checkout master + submodule update : gmock/.git is created
* checkout hammer : the gmock directory still contains the .git from
master because it did not exist at the time and checkout won't
remove untracked directories
* checkout master + submodule update : git rev-parse HEAD is
at the desired commit although the content of the gmock directory
is from hammer
http://tracker.ceph.com/issues/11157 Fixes: #11157
Signed-off-by: Loic Dachary <ldachary@redhat.com>
|
SUCCESS: run-make-check.sh on centos-7 (no output because pastebinit failed) |
Sent from
ghost
pushed a commit
that referenced
this pull request
Mar 21, 2015
doc,tests: force checkout of submodules Reviewed-by: David Zafman <dzafman@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating submodules, always checkout even if the HEAD is the
desired commit hash (update --force) to avoid the following:
http://tracker.ceph.com/issues/11157 Fixes: #11157
Signed-off-by: Loic Dachary ldachary@redhat.com