doc: missing man pages for ceph-create-keys, ceph-disk-* #4846
Conversation
smithfarm
force-pushed
the
wip-11862-hammer
branch
from
c204b93
to
1449301
Compare
|
@tchaikov can you take a look? |
|
once it is also added into the rpm spec file. and confirmed by the gitbuilders. @smithfarm i'd suggest you to push it to a wip branch to get it tested with the tireless builders. |
|
@tchaikov: I noticed that http://tracker.ceph.com/issues/10725 is asking for 4 manpages, but it looks like you resolved it after adding only this one . . . (?) Should we open issues for the remaining 3? |
|
i don't think so. see http://tracker.ceph.com/issues/10725#note-11 . |
|
@tchaikov I think the make-check bot is paused, see Loic's email to ceph-devel delivered to me today 2015-06-03 at 01:48 CEST. |
okay. would you mind pushing it to ceph repo to get it built by gitbuilders? |
| :program:`ceph-create-keys` is a utility to generate bootstrap keyrings using | ||
| the given monitor when it is ready. | ||
|
|
||
| it creates following auth entities (or users) |
There was a problem hiding this comment.
Sorry didn't notice that this was a backport PR.. Guess it should be fine either way
There was a problem hiding this comment.
@theanalyst might be a chance to fix it though. we could add a note in the commit message for this small edit.
There was a problem hiding this comment.
as long as it gets fixed in master too so it doesn't get lost :)
There was a problem hiding this comment.
... or should I say "It" doesn't get lost! 😆
to address the comments on ceph#4846 Signed-off-by: Kefu Chai <kchai@redhat.com>
to address the comments on ceph#4846 Fixes: ceph#10725 Signed-off-by: Kefu Chai <kchai@redhat.com>
smithfarm
force-pushed
the
wip-11862-hammer
branch
from
1449301
to
4ba106b
Compare
|
@smithfarm i am sure if i follow you, but the cherry-pick from 27cee2f is missing some |
to address the comments on ceph#4846 Fixes: ceph#10725 Signed-off-by: Kefu Chai <kchai@redhat.com>
to address the comments on ceph#4846 Fixes: ceph#10725 Signed-off-by: Kefu Chai <kchai@redhat.com>
Fixes: ceph#10725 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 27cee2f) Conflicts: doc/man/8/ceph-create-keys.rst Includes fixes from ceph#4855
This is the generated manpage, taken from a local build of master Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit bcda61f)
smithfarm
force-pushed
the
wip-11862-hammer
branch
from
4ba106b
to
5a60a03
Compare
|
@tchaikov: added the missing bit in |
|
@smithfarm no, thanks! |
|
LGTM
|
missing man pages for ceph-create-keys, ceph-disk-* Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
ghost
merged commit 
ghost
changed the title
http://tracker.ceph.com/issues/11862