librbd: aio calls may block #4854

dillaman · 2015-06-04T00:06:39Z

http://tracker.ceph.com/issues/11769

dillaman · 2015-06-08T13:37:33Z

Passed RBD teuthology suite

ghost · 2015-06-12T09:14:38Z

@dillaman it would be good to have comments in the commit messages regarding conflict resolution (reminder ;-)

loic-bot · 2015-06-22T21:13:50Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/6026/

SUCCESS http://jenkins.ceph.dachary.org/job/ceph/LABELS=centos-7&&x86_64/6026/

smithfarm · 2015-07-24T10:20:48Z

@dachary @dillaman wrote that this PR has already passed an RBD suite, but in view of its complexity should we put it in the next integration test round so it gets tested some more?

ghost · 2015-07-24T12:22:56Z

@dillaman would you be so kind as to rebase & re-push this PR so that it triggers the make check bot ? I do not remember why I changed to DNM, I suspect it's just because it failed compilation in the integration branch. But I failed to mention the reason for the change.

…gleton If some objects associated to CephContext want to create a singleton object, it can inherit AssociatedSingletonObject and implement destruction to get notified. Signed-off-by: Haomai Wang <haomaiwang@gmail.com> (cherry picked from commit 7fed5de)

This was broken by 7fed5de Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 9029813)

The queue holds a collection of Context pointers that will be completed by the thread pool. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 24a33e9) Conflicts: src/common/WorkQueue.h: trivial resolution

Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit b3f5a75)

Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit afb896d) Conflicts: src/common/config_opts.h: trivial resolution src/librbd/ImageCtx.cc: trivial resolution src/librbd/ImageCtx.h: trivial resolution src/librbd/internal.cc: trivial resolution

Enqueue all AIO API methods within the new librbd thread pool to reduce the possibility of any blocking operations. To maintain backwards compatibility with the legacy return codes of the API's AIO methods, it's still possible to block attempting to acquire the snap_lock. Fixes: #11056 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 3a7b5e3) Conflicts: src/librbd/librbd.cc: trivial resolution

Helper method to handle passing fatal errors generated within librbd (not from the OSDs) back to the client. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 6d1d0c8) Conflicts: src/librbd/AioCompletion.cc: trivial resolution src/librbd/AioCompletion.h: trivial resolution

Allow the client of SimpleThrottle to detect an async error so that it can exit early. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit b88b88c)

All failures should be returned via the AioCompletion. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 9ab42d6) Conflicts: src/librbd/AioRequest.cc: trivial resolution src/librbd/internal.cc: trivial resolution src/librbd/internal.h: trivial resolution

The librados calls used by AioRequest::send should always return zero unless there is a bug. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit c77bce3) Conflicts: src/librbd/AioRequest.cc: trivial resolution src/librbd/AioRequest.h: trivial resolution src/librbd/internal.cc: trivial resolution

Signed-off-by: Jason Dillaman <dillaman@redhat.com> Conflicts: src/test/librbd/test_librbd.cc: trivial resolution

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Setting this option to false reverts librbd to legacy behavior where AIO operations could potentially block. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 769cad1) Conflicts: src/common/config_opts.h: trivial resolution src/librbd/librbd.cc: trivial resolution

Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 4cf4148)

dillaman · 2015-07-24T14:05:07Z

@dachary Rebased and pushed. @smithfarm This fix is actually already available within the downstream Red Hat Ceph Storage 1.2.x product, so the sooner we can get it in upstream, the better in my humble opinion.

ghost · 2015-07-24T14:31:08Z

@dillaman is the patch id of all the commits the same ? How much testing did it see ?

smithfarm · 2015-07-24T14:32:19Z

@dillaman: JFYI the tracker issue says "DNM until Josh provides +1"

dillaman · 2015-07-24T14:36:48Z

@jdurgin Thoughts?

smithfarm · 2015-07-24T14:46:28Z

(We will run integration tests on this before merging it in any case.)

ghost · 2015-07-24T15:15:39Z

@dillaman @smithfarm my concern here is to avoid having a significant amount of commits that look like they are different in hammer and in another context (redhat or suse product), because of tiny differences that change the patch id. For all intent and purposes such commits are the same but from the point of view of a tool, they are different (git cherry will find them different) and it takes a human being to compare them and decide the difference is not significant.

If the commits that exist elsewhere did not see much testing and have not been released yet, the commits from this pull request could probably just be used to replace them. If the commits that exist elsewhere have been extensively tested, and if their patch-id is different, it is very little effort to update this pull request with them (replace the current ones), for the sake of having a clean history.

Hopefully that clarifies a little the context in which I asked "is the patch id of all the commits the same ? How much testing did it see ? ".

Sorry for being so terse ;-)

P.S. See also http://www.spinics.net/lists/ceph-devel/msg24489.html

ghost · 2015-07-24T17:21:15Z

All but two commits have the same patch-id in v0.80.8.2. The reason for these divergences are explained in the "reconciliation between firefly and v0.80.8.2" mail on ceph-devel.

ghost · 2015-07-24T17:24:25Z

@smithfarm no further comment, all is well :-)

jdurgin · 2015-07-24T18:33:23Z

No problems from this in master. Looks good to me once it passes through the rbd suite. Generally you can assume that for trivial backports, or ones with just trivial conflicts, I'm fine with merging them after an rbd suite run.

loic-bot · 2015-07-24T19:27:30Z

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/6643/

smithfarm · 2015-09-02T08:39:11Z

@jdurgin: it passed the rbd suite. OK to merge? ( see http://tracker.ceph.com/issues/11644#rbd )

jdurgin · 2015-09-03T06:29:28Z

@smithfarm yup, lgtm

librbd: aio calls may block Reviewed-by: Josh Durgin <jdurgin@redhat.com>

dillaman added bug-fix rbd labels Jun 4, 2015

dillaman added this to the firefly milestone Jun 4, 2015

dillaman mentioned this pull request Jun 4, 2015

[DNM] librbd: avoid blocking AIO API methods #4364

Closed

dillaman force-pushed the wip-11769-firefly branch 2 times, most recently from 9a5427f to 78afe97 Compare June 5, 2015 20:10

ghost self-assigned this Jun 12, 2015

ghost changed the title ~~librbd: aio calls may block~~ DNM: librbd: aio calls may block Jun 12, 2015

dillaman force-pushed the wip-11769-firefly branch from 78afe97 to 0c665d0 Compare June 22, 2015 20:03

dillaman changed the title ~~DNM: librbd: aio calls may block~~ librbd: aio calls may block Jun 22, 2015

ghost changed the title ~~librbd: aio calls may block~~ [DNM] librbd: aio calls may block Jul 8, 2015

yuyuyu101 and others added 14 commits July 24, 2015 09:59

common/ceph_context: don't import std namespace

94aa947

This was broken by 7fed5de Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 9029813)

WorkQueue: add new ContextWQ work queue

9bf970c

The queue holds a collection of Context pointers that will be completed by the thread pool. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 24a33e9) Conflicts: src/common/WorkQueue.h: trivial resolution

WorkQueue: added virtual destructor

3292bd2

Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit b3f5a75)

Throttle: added pending_error method to SimpleThrottle

e480404

Allow the client of SimpleThrottle to detect an async error so that it can exit early. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit b88b88c)

tests: update librbd AIO tests to remove result code

861c20b

Signed-off-by: Jason Dillaman <dillaman@redhat.com> Conflicts: src/test/librbd/test_librbd.cc: trivial resolution

PendingReleaseNotes: document changes to librbd's aio_read methods

6886396

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

tests: verify librbd blocking aio code path

4a709a4

Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 4cf4148)

dillaman force-pushed the wip-11769-firefly branch from 0c665d0 to 4a709a4 Compare July 24, 2015 14:00

dillaman changed the title ~~[DNM] librbd: aio calls may block~~ librbd: aio calls may block Jul 24, 2015

smithfarm added a commit that referenced this pull request Sep 3, 2015

Merge pull request #4854 from ceph/wip-11769-firefly

99612e7

librbd: aio calls may block Reviewed-by: Josh Durgin <jdurgin@redhat.com>

smithfarm merged commit 99612e7 into firefly Sep 3, 2015

smithfarm deleted the wip-11769-firefly branch September 3, 2015 10:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

librbd: aio calls may block #4854

librbd: aio calls may block #4854

dillaman commented Jun 4, 2015

dillaman commented Jun 8, 2015

ghost commented Jun 12, 2015

loic-bot commented Jun 22, 2015

smithfarm commented Jul 24, 2015

ghost commented Jul 24, 2015

dillaman commented Jul 24, 2015

ghost commented Jul 24, 2015

smithfarm commented Jul 24, 2015

dillaman commented Jul 24, 2015

smithfarm commented Jul 24, 2015

ghost commented Jul 24, 2015

ghost commented Jul 24, 2015

ghost commented Jul 24, 2015

jdurgin commented Jul 24, 2015

loic-bot commented Jul 24, 2015

smithfarm commented Sep 2, 2015

jdurgin commented Sep 3, 2015

librbd: aio calls may block #4854

librbd: aio calls may block #4854

Conversation

dillaman commented Jun 4, 2015

dillaman commented Jun 8, 2015

ghost commented Jun 12, 2015

loic-bot commented Jun 22, 2015

smithfarm commented Jul 24, 2015

ghost commented Jul 24, 2015

dillaman commented Jul 24, 2015

ghost commented Jul 24, 2015

smithfarm commented Jul 24, 2015

dillaman commented Jul 24, 2015

smithfarm commented Jul 24, 2015

ghost commented Jul 24, 2015

ghost commented Jul 24, 2015

ghost commented Jul 24, 2015

jdurgin commented Jul 24, 2015

loic-bot commented Jul 24, 2015

smithfarm commented Sep 2, 2015

jdurgin commented Sep 3, 2015