Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic control optracker #5168

Merged
merged 5 commits into from Nov 11, 2015
Merged

Dynamic control optracker #5168

merged 5 commits into from Nov 11, 2015

Conversation

majianpeng
Copy link
Member

make osd/mds can dynamic control optracker settting.

@loic-bot
Copy link

loic-bot commented Jul 8, 2015

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/6276/

@majianpeng
Copy link
Member Author

@tchaikov . Have you time review this? Thanks!

@loic-bot
Copy link

loic-bot commented Jul 8, 2015

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/6277/

@tchaikov tchaikov self-assigned this Jul 8, 2015
@tchaikov
Copy link
Contributor

tchaikov commented Jul 9, 2015

@majianpeng generally looks good. we might want to add this to the pending release notes.
but @athanatos might also need to review this.

@gregsfortytwo
Copy link
Member

I think the dynamic control is okay, but we definitely want to leave the optracker enabled by default. It's just too useful for debugging when user clusters get stuck, but that doesn't work if the tracking was off when things broke.

@majianpeng majianpeng force-pushed the dynamic-control-optracker branch 2 times, most recently from d15abb9 to 7562db8 Compare July 10, 2015 01:38
@loic-bot
Copy link

FAILURE: http://jenkins.ceph.dachary.org/job/ceph/6326/

@majianpeng
Copy link
Member Author

@dachary . Can you fix this failure(not related w/ my code)? Thanks!

@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/6328/

@gregsfortytwo gregsfortytwo mentioned this pull request Jul 10, 2015
Merged
@tchaikov
Copy link
Contributor

lgtm after a rados qa run.

@ghost
Copy link

ghost commented Sep 1, 2015

@majianpeng it needs rebasing

@tchaikov tchaikov assigned majianpeng and unassigned tchaikov Sep 2, 2015
@tchaikov
Copy link
Contributor

@majianpeng ping?

@majianpeng
osd/ReplicatedPG: for osd_op_create, if ob existed don't do t->touch.
7532194 
Although if ob existed, t->touch don't meet error. But this cause one
transaction include write journal.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@majianpeng
common/TrackedOp: Should lock ops_history_lock when access shutdown.
7fe72a2 
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@majianpeng
common/TrackedOp: make Tracker can dynamic control.
01f816a 
After osd/mds initating, the optracker can't set. For dynamic
control, we can set optracker enable or disable at any time.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@majianpeng
osd: Make osd can dynamic set optracker via asok.
4aaa123 
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@majianpeng
mds: Make mds can dynamic set optracker via asok.
52bbeb1 
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@majianpeng
Copy link
Member Author

@tchaikov . Rebased. Thanks!

@loic-bot
Copy link

FAILURE: http://jenkins.ceph.dachary.org/job/ceph/7837/

@ghost
Copy link

ghost commented Sep 18, 2015

Please ignore the make check bot error on Ubuntu, it is a false negative (http://tracker.ceph.com/issues/13136).

@tchaikov
Copy link
Contributor

@majianpeng not sure why your change fails the test of http://pulpito.ceph.com/kchai-2015-09-25_06:02:07-rados-wip-kefu-testing---basic-multi/1068857/ . i am removing your pr from my test branch at this moment.

liewegas added a commit that referenced this pull request Nov 11, 2015
@liewegas
Merge pull request #5168 from majianpeng/dynamic-control-optracker
dde76ae 
common: allow enable/disable of optracker at runtime

Reviewed-by: Kefu Chai <kchai@redhat.com>
@liewegas liewegas merged commit dde76ae into ceph:master Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@majianpeng majianpeng

Labels
common feature needs-qa wip-sage-testing
Projects
None yet
Milestone
No milestone
5 participants
@majianpeng @loic-bot @tchaikov @gregsfortytwo @liewegas