New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: TEST_crush_reject_empty must not run a mon #5208
Conversation
After a make check fails, it shows a summary but not the output of the failed tests although they contain information to diagnose the problem. Set the VERBOSE=true automake variable which is documented to collect and display the failed script output at the end of a run (the content of the test-suite.log file (valid from automake-1.11 up). http://www.gnu.org/software/automake/manual/automake.html#index-VERBOSE Also remove the run-make-check.sh that did the same in a way that is not compatible with automake-1.11. Signed-off-by: Loic Dachary <ldachary@redhat.com> (cherry picked from commit 3a55cb0)
To display the output in case the command did not fail with the expected output. Signed-off-by: Loic Dachary <ldachary@redhat.com> (cherry picked from commit 5871781)
a470929
to
f56b3e0
Compare
@tchaikov can we maybe keep EPERM instead to minimize the extent of the change and avoid on non-cherry pick in the stable branch ? |
we could, but if we keep
the first item is what i don't really like.
will do. |
* Back in Hammer, the osd-crush.sh individual tests did not run the monitor, it was taken care of by the run() function. An attempt to run another mon fails with: error: IO lock testdir/osd-crush/a/store.db/LOCK: Resource temporarily unavailable This problem was introduced by cc1cc03 from ceph#4936 * replace test/mon/mon-test-helpers.sh with test/ceph-helpers.sh as we need run_osd() in this newly added test * update the run-dir of commands: ceph-helpers.sh use the different convention for the run-dir of daemons. http://tracker.ceph.com/issues/11975 Refs: ceph#11975 Signed-off-by: Loic Dachary <ldachary@redhat.com>
this backports a tiny part of ec02441, otherwise CrushTester will return 1, and "ceph" cli will take it as EPERM, which is miss leading, and fails osd-crush.sh:TEST_crush_reject_empty. Signed-off-by: Kefu Chai <kchai@redhat.com>
f56b3e0
to
7f1c0cc
Compare
@tchaikov you are right, EINVAL is needed. Reviewed-by: Loic Dachary <ldachary@redhat.com> |
tests: TEST_crush_reject_empty must not run a mon Reviewed-by: Loic Dachary <ldachary@redhat.com>
thanks for your review @dachary , and i am very sorry for the noise in the backport pull requests. =( |
http://tracker.ceph.com/issues/12285 and http://tracker.ceph.com/issues/11975
this pull request adds some commits on top of #5195 to make
osd-crush.sh
tests happy.