radosgw-admin: Create --secret-key alias for --secret #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit pick: the typo in the title. =) |
zhouyuan
force-pushed
the
radosgw_admin_secret_key_alias
branch
from
58c9c1a
to
5db5825
Compare
zhouyuan
changed the title
|
@tchaikov Thanks! It's fixed now. |
| @@ -1172,7 +1173,7 @@ int main(int argc, char **argv) | |||
| access_key = val; | |||
| } else if (ceph_argparse_witharg(args, i, &val, "--subuser", (char*)NULL)) { | |||
| subuser = val; | |||
| } else if (ceph_argparse_witharg(args, i, &val, "--secret", (char*)NULL)) { | |||
| } else if (ceph_argparse_witharg(args, i, &val, "--secret", "--secrte-key", (char*)NULL)) { | |||
| secret_key = val; | |||
There was a problem hiding this comment.
@theanalyst thank you! fixed.
zhouyuan
force-pushed
the
radosgw_admin_secret_key_alias
branch
3 times, most recently
from
e446c15
to
a10bce0
Compare
|
LGTM |
|
@zhouyuan there's a merge conflict, I can't merge it, can you rebase it? Thanks |
Fixes: ceph#5821 Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
force-pushed
the
radosgw_admin_secret_key_alias
branch
from
a10bce0
to
2938fdd
Compare
|
@yehudasa rebased on the master. Thanks for the review! |
|
@zhouyuan please ignore the bot failure, this is a false negative ( http://tracker.ceph.com/issues/12340 ). |
yehudasa
added a commit
that referenced
this pull request
Oct 15, 2015
radosgw-admin: Create --secret-key alias for --secret Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5821
Signed-off-by: Yuan Zhou yuan.zhou@intel.com