Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: register_new_pgs() should check ruleno instead of its index #5404

Merged
merged 1 commit into from Sep 9, 2015

Conversation

smithfarm
Copy link
Contributor

when some rules have been deleted before, the index in array of crush->rules
is not always equals to crush_ruleset of pool.

Fixes: ceph#12210
Reported-by: Ning Yao <zay11022@gmail.com>
Signed-off-by: Xinze Chi <xmdxcxz@gmail.com>
(cherry picked from commit 4987933)
@smithfarm smithfarm self-assigned this Jul 29, 2015
@smithfarm smithfarm added this to the firefly milestone Jul 29, 2015
@smithfarm
Copy link
Contributor Author

@tchaikov This has passed a rados suite (see http://tracker.ceph.com/issues/11644#rados for details). OK to merge, do you think?

@smithfarm smithfarm assigned tchaikov and unassigned smithfarm Sep 7, 2015
@tchaikov tchaikov assigned smithfarm and unassigned tchaikov Sep 9, 2015
@tchaikov
Copy link
Contributor

tchaikov commented Sep 9, 2015

lgtm.

smithfarm added a commit that referenced this pull request Sep 9, 2015
register_new_pgs() should check ruleno instead of its index

Reviewed-by: Kefu Chai <kchai@redhat.com>
@smithfarm smithfarm merged commit 973b74d into ceph:firefly Sep 9, 2015
@smithfarm smithfarm deleted the wip-12395-firefly branch September 9, 2015 04:07
@ghost ghost changed the title register_new_pgs() should check ruleno instead of its index mon: register_new_pgs() should check ruleno instead of its index Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants